After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779933 - Cancelling a clone doesn't actually cancel it
Cancelling a clone doesn't actually cancel it
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: general
Flatpak Nightly Channel
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-03-12 10:46 UTC by Carlos Soriano
Modified: 2017-03-13 05:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
greeter: connect cancel button up to GCancellable (3.09 KB, patch)
2017-03-13 05:05 UTC, Christian Hergert 		committed Details | Review
git: allow notifying git callbacks they have been cancelled (3.64 KB, patch)
2017-03-13 05:05 UTC, Christian Hergert 		committed Details | Review
git: wire up cancellation of clone UI (4.00 KB, patch)
2017-03-13 05:05 UTC, Christian Hergert 		committed Details | Review

Description Carlos Soriano 2017-03-12 10:46:34 UTC 
Trying to clone a project, clicked cancel, it returned to the greeter. Then clicked clone again and the previous project was there still downloading. After a few seconds that project opened, even if clicked cancel several times.
Comment 1 Christian Hergert 2017-03-13 05:05:45 UTC 
Created attachment 347791 [details] [review]
greeter: connect cancel button up to GCancellable

This was an omission where we just didn't have the cancellable connected
to the cancel button so that clone operations could self-cancel.
Comment 2 Christian Hergert 2017-03-13 05:05:48 UTC 
Created attachment 347792 [details] [review]
git: allow notifying git callbacks they have been cancelled

We still don't have a way to make the clone to truely stop using the
ggit_repository_clone() API, but this will allow us to stop sending update
property notifications
Comment 3 Christian Hergert 2017-03-13 05:05:52 UTC 
Created attachment 347793 [details] [review]
git: wire up cancellation of clone UI

If the operation was cancelled, we need to reset the UI.
Comment 4 Christian Hergert 2017-03-13 05:06:40 UTC 
Attachment 347791 [details] pushed as 9a78cd4 - greeter: connect cancel button up to GCancellable
Attachment 347792 [details] pushed as f5c761c - git: allow notifying git callbacks they have been cancelled
Attachment 347793 [details] pushed as 8dcf96d - git: wire up cancellation of clone UI