After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779879 - meson: actually use optional dependencies
meson: actually use optional dependencies
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-03-10 22:34 UTC by Ernestas Kulik
Modified: 2017-03-10 22:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
meson: actually use optional dependencies (3.62 KB, patch)
2017-03-10 22:34 UTC, Ernestas Kulik 		committed Details | Review

Description Ernestas Kulik 2017-03-10 22:34:23 UTC 
EXIF and Exempi are currently only being detected due to an oversight.
This commit makes Meson define the preprocessor macros needed to use the
libraries.
Comment 1 Ernestas Kulik 2017-03-10 22:34:27 UTC 
Created attachment 347673 [details] [review]
meson: actually use optional dependencies
Comment 2 Ernestas Kulik 2017-03-10 22:35:16 UTC 
A very big oops.
Comment 3 Carlos Soriano 2017-03-10 22:36:18 UTC 
Review of attachment 347673 [details] [review]:

Aha! this makes much more sense, I knew something was wrong checking for dependency before the option is evaluated :)

LGTM!
Comment 4 Ernestas Kulik 2017-03-10 22:40:57 UTC 
Attachment 347673 [details] pushed as 63a7e1e - meson: actually use optional dependencies