After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779420 - Meson build fails on Continuous
Meson build fails on Continuous
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
master
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-03-01 13:57 UTC by Ernestas Kulik
Modified: 2017-03-10 22:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
meson: add enum types header to libnautilus dep sources (1.54 KB, patch)
2017-03-01 14:01 UTC, Ernestas Kulik 		none Details | Review
search-provider: include header, not the source (814 bytes, patch)
2017-03-01 14:14 UTC, Ernestas Kulik 		committed Details | Review
meson: make doc generation opt-in (1.26 KB, patch)
2017-03-01 16:10 UTC, Ernestas Kulik 		committed Details | Review

Description Ernestas Kulik 2017-03-01 13:57:01 UTC 
Patches for that will go here.
Comment 1 Ernestas Kulik 2017-03-01 14:01:47 UTC 
Created attachment 346969 [details] [review]
meson: add enum types header to libnautilus dep sources

Generated libnautilus sources need to be passed down to the dependents
to ensure proper build order.
Comment 2 Ernestas Kulik 2017-03-01 14:14:54 UTC 
Created attachment 346971 [details] [review]
search-provider: include header, not the source

Currently, the generated enum types source is included, which is
unnecessary.
Comment 3 Carlos Soriano 2017-03-01 14:41:39 UTC 
Review of attachment 346971 [details] [review]:

+1
Comment 4 Ernestas Kulik 2017-03-01 14:49:33 UTC 
Comment on attachment 346971 [details] [review]
search-provider: include header, not the source

Attachment 346971 [details] pushed as d4d2fb6 - search-provider: include header, not the source
Comment 5 Ernestas Kulik 2017-03-01 16:10:20 UTC 
Created attachment 346978 [details] [review]
meson: make doc generation opt-in

Since Continuous does not have GTK-Doc and jhbuild users don’t usually
care about generating documentation, it makes sense to disable it by
default.
Comment 6 Carlos Soriano 2017-03-01 16:14:50 UTC 
Review of attachment 346978 [details] [review]:

Sure
Comment 7 Ernestas Kulik 2017-03-01 16:15:48 UTC 
Comment on attachment 346978 [details] [review]
meson: make doc generation opt-in

Attachment 346978 [details] pushed as 2c22594 - meson: make doc generation opt-in