GNOME Bugzilla – Bug 775604
Removed overview items are not replaced by new items
Last modified: 2016-12-05 03:09:16 UTC
When removing an item from the overview, it's supposed to be replaced by a new item from history. At first I thought it was a regression from 'web-overview: Don't ever duplicate thumbnails' but reverting that commit did not help. Then I did a bisect and discovered it broke in "overview: Fix for animation when removing item" (bug #772350). We can't just revert that commit since the animation really is very broken without it, so needs further investigation to see what went wrong.
Estêvão, any chance you have time to look into it? (No problem if not, I know you've got plenty going on. :)
Actually I found the problem. I broke setting the overview-removed style class in "Improve overview layout in small windows", then you fixed that in "overview: Fix for animation when removing item", but now nothing ever removes the class so the item stays hidden forever.
The following fixes have been pushed: 162859f web-overview: Properly show new overview item after removing one 363d6ca about-handler: Simplify overview JS
Created attachment 341361 [details] [review] web-overview: Properly show new overview item after removing one This has been broken since I got rid of the list that was previously used to hold overview items. The style class now lives on the anchor itself and not its parent element.
Created attachment 341362 [details] [review] about-handler: Simplify overview JS This variable isn't needed anymore, and we don't use a list anymore anyway.