GNOME Bugzilla – Bug 772554
libs: minor correction for logical consistency
Last modified: 2016-10-31 14:34:25 UTC
There are some logically invalid ref/unref methods, which are being used. 1. GstVaapiDecoder is inherited from GstVaapiMiniObject. But it call gst_vaapi_object_replace instead of gst_vaapi_mini_object_replace 2. GstVaapiPixmap,Window,Texture are inherited from GstVaapiObject. But it call gst_vaapi_mini_object_ref/unref/replace directly. These are not critical because gst_vaapi_object_ref/unref/replace calls gst_vaapi_mini_object_ref/unref/replace directly. But for consistency, we should change this, IMO. Especially for 1, it should be changed.
Created attachment 337139 [details] [review] libs: minor correction for logical consistency
Review of attachment 337139 [details] [review]: lgtm. Not sure if we should apply it now or after release, since it is just consistency, and it will be modified when gstobjectivation advance.
Created attachment 337493 [details] [review] libs: minor correction for logical consistency Added a case of gstvaapiencoder
(In reply to Víctor Manuel Jáquez Leal from comment #2) > Review of attachment 337139 [details] [review] [review]: > > lgtm. > > Not sure if we should apply it now or after release, since it is just > consistency, and it will be modified when gstobjectivation advance. It's okay of merge after release. And I think it'd be better to be seperated from gstobject conversion.
Attachment 337493 [details] pushed as abc2480 - libs: minor correction for logical consistency
Victor, thanx for merge but I found the thing about gstvaapiencoder is dropped on git. Probably, you merged the first patch instead of the second patch :)