GNOME Bugzilla – Bug 771614
No animation for rename popup.
Last modified: 2017-01-05 16:05:29 UTC
No animation for rename popup. See comparsion between 3.20 vs 3.22 https://youtu.be/gg8763UcCK8
Created attachment 338638 [details] [review] rename-file-popover-controller: Fix popover animation The transitions for the rename popover are disabled. To fix this, use gtk_popover_popdown and gtk_popover_popup instead of gtk_widget_show and gtk_widget_hide.
Review of attachment 338638 [details] [review]: LGTM. Pressing escape still only hides them, but that is GTK+, not Nautilus. I will see if I can convince GTK+ people to do popdowns instead of hides. :p
Attachment 338638 [details] pushed as 3a7ec46 - rename-file-popover-controller: Fix popover animation
(In reply to Alexandru Pandelea from comment #3) > Attachment 338638 [details] pushed as 3a7ec46 - > rename-file-popover-controller: Fix popover animation Will we see this fix in the 320?
Created attachment 339262 [details] [review] files-view: use gtk_popover_pop{up,down} for rename popover Popover transitions are not used for the rename popover.
(In reply to Maxim from comment #4) > (In reply to Alexandru Pandelea from comment #3) > > Attachment 338638 [details] pushed as 3a7ec46 - > > rename-file-popover-controller: Fix popover animation > > Will we see this fix in the 320? That particular patch does not apply to the branch. I have posted one in comment 5.
Review of attachment 339262 [details] [review]: oh yes, sorry for taking long to review!
Comment on attachment 339262 [details] [review] files-view: use gtk_popover_pop{up,down} for rename popover Attachment 339262 [details] pushed as d3ff53d - files-view: use gtk_popover_pop{up,down} for rename popover
reverted in 3.20, we didn't have gtk_popover_popdown back then