After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771114 - batch rename: '.' and '..' should be folder names when renaming folders
batch rename: '.' and '..' should be folder names when renaming folders
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: File and Folder Operations
3.21.x
Other Linux
: Normal minor
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-09-09 11:12 UTC by Mohammed Sadiq
Modified: 2017-08-18 12:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Batch rename: display message fixed (1.38 KB, patch)
2016-11-19 18:45 UTC, Olaru Mihai Alexandru
reviewed Details | Review
batch-rename-dialog: Use better wording (1.84 KB, patch)
2017-08-18 12:50 UTC, Carlos Soriano
committed Details | Review

Description Mohammed Sadiq 2016-09-09 11:12:03 UTC
when '.' and '..' are listed as file names when renaming folders, the conflict message says: ".." is an unallowed file name

Instead, the conflict message can be: ".." is an unallowed name (just avoid the 'file')
Comment 1 Olaru Mihai Alexandru 2016-11-19 18:45:00 UTC
Created attachment 340322 [details] [review]
Batch rename: display message fixed

I fixed the conflict message when you're trying to create a directory with '.' and '..' name, from "is an unallowed file name" in "is an unallowed name".
Comment 2 Carlos Soriano 2016-11-21 09:41:56 UTC
Review of attachment 340322 [details] [review]:

Hey Mihai,

Thanks for the patch!!

The commit message has small issues, you have a guide for doing good commit messages in https://wiki.gnome.org/Newcomers/CodeContributionWorkflow#Commit_guidelines. In this case:
- The file name should be as how it is in the filesystem but whithouh the nautilus- prefix and withouth the file extension. So in this case, batch-rename-dialog.
- Don't use "I"
- Needs to explain why the change
- Use the present and imperative form of verbs

If you have any doubts feel free to ping me in IRC :)
Comment 3 Ernestas Kulik 2017-08-18 10:57:40 UTC
Review of attachment 340322 [details] [review]:

I would also change the string to something like “is not a valid name”. A bit less awkwardly worded.
Comment 4 Carlos Soriano 2017-08-18 12:50:42 UTC
Created attachment 357895 [details] [review]
batch-rename-dialog: Use better wording

Nautilus was using "unallowed" which sounds odd and also "file name"
when in reality can also be folders.
Comment 5 Carlos Soriano 2017-08-18 12:51:56 UTC
I actually reworked it to use better wording in general.

Attachment 357895 [details] pushed as 9db6240 - batch-rename-dialog: Use better wording