After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770594 - Plural support for new batch rename strings
Plural support for new batch rename strings
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Internationalization (i18n)
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-08-30 12:22 UTC by Piotr Drąg
Modified: 2016-08-30 20:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
batch-rename-dialog: add plural support for strings (1.22 KB, patch)
2016-08-30 13:44 UTC, Alexandru Pandelea
committed Details | Review
file-undo-operations: add plural support for strings (1.66 KB, patch)
2016-08-30 19:03 UTC, Alexandru Pandelea
none Details | Review
file-undo-operations: add plural support for strings (1.65 KB, patch)
2016-08-30 19:12 UTC, Alexandru Pandelea
committed Details | Review

Description Piotr Drąg 2016-08-30 12:22:39 UTC
Similar to bug #770270, but this time for "Batch rename '%d' files".

https://wiki.gnome.org/TranslationProject/DevGuidelines/Plurals
Comment 1 Alexandru Pandelea 2016-08-30 13:44:41 UTC
Created attachment 334448 [details] [review]
batch-rename-dialog: add plural support for strings

The title of the dialog didn't have plural support.
Comment 2 Carlos Soriano 2016-08-30 14:59:41 UTC
Review of attachment 334448 [details] [review]:

yep thanks!
Comment 3 Carlos Soriano 2016-08-30 15:00:23 UTC
btw thanks Piotr for all the fixes in https://git.gnome.org/browse/nautilus/commit/?id=8ef1b6f2934eb49ca3923329d5ac749f5ec69de4 !!
Comment 4 Piotr Drąg 2016-08-30 16:31:08 UTC
This is an excellent patch, but I was talking about a different string:

#: src/nautilus-file-undo-operations.c:1106
#: src/nautilus-file-undo-operations.c:1108
#, c-format
msgid "Batch rename '%d' files"
msgstr ""
Comment 5 Alexandru Pandelea 2016-08-30 19:02:57 UTC
(In reply to Piotr Drąg from comment #4)
> This is an excellent patch, but I was talking about a different string:
> 
> #: src/nautilus-file-undo-operations.c:1106
> #: src/nautilus-file-undo-operations.c:1108
> #, c-format
> msgid "Batch rename '%d' files"
> msgstr ""

Yes, this also needs to be changed, I'll add a patch now.
Comment 6 Alexandru Pandelea 2016-08-30 19:03:53 UTC
Created attachment 334475 [details] [review]
file-undo-operations: add plural support for strings

The undo and redo descriptions didn't have plural support
Comment 7 Piotr Drąg 2016-08-30 19:05:50 UTC
The number of files probably doesn't need the quotation marks.
Comment 8 Alexandru Pandelea 2016-08-30 19:12:38 UTC
Created attachment 334481 [details] [review]
file-undo-operations: add plural support for strings

The undo and redo descriptions didn't have plural support
Comment 9 Carlos Soriano 2016-08-30 19:53:23 UTC
Review of attachment 334481 [details] [review]:

makes sense, thanks!
Comment 10 Alexandru Pandelea 2016-08-30 20:40:15 UTC
Attachment 334448 [details] pushed as df6dd26 - batch-rename-dialog: add plural support for strings
Attachment 334481 [details] pushed as 945b3e5 - file-undo-operations: add plural support for strings