After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 770462 - Rhythmbox should not display "Examining files 0 of 0"
Rhythmbox should not display "Examining files 0 of 0"
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Importing
HEAD
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-08-26 22:30 UTC by gnome.vrb
Modified: 2016-09-24 09:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Examining files 0 of 0 (84.97 KB, video/webm)
2016-08-26 22:30 UTC, gnome.vrb 		  Details
Update task-detail only if have entries to process (712 bytes, patch)
2016-09-10 05:34 UTC, gnome.vrb 		committed Details | Review
Minor cleanup ( use add rather than import - in line with ENTRY_ADDED ) (2.67 KB, patch)
2016-09-10 06:34 UTC, gnome.vrb 		rejected Details | Review

Description gnome.vrb 2016-08-26 22:30:26 UTC 
Created attachment 334250 [details]
Examining files 0 of 0

When trying to do an import, the default selected folder is examined for possible content. If the number of entries to examine is 0, then Rhythmbox should not show an "Examining files 0 of 0" in the display.

Refer to attached screencast.
Comment 1 gnome.vrb 2016-09-10 05:34:18 UTC 
Created attachment 335227 [details] [review]
Update task-detail only if have entries to process
Comment 2 gnome.vrb 2016-09-10 06:34:15 UTC 
Created attachment 335228 [details] [review]
Minor cleanup ( use add rather than import - in line with ENTRY_ADDED )
Comment 3 Jonathan Matthew 2016-09-24 08:44:13 UTC 
Review of attachment 335227 [details] [review]:

I adjusted this a bit and pushed it as commit ae27214
Comment 4 Jonathan Matthew 2016-09-24 09:25:38 UTC 
Review of attachment 335228 [details] [review]:

I don't really see this as an improvement.  I think it's pretty clear what 'imported' means in this context, whereas 'added' could be confused with the uris added to the job, which are the locations to be scanned.