GNOME Bugzilla – Bug 769651
Add webp file format support to gimp master
Last modified: 2016-10-25 13:16:38 UTC
Created attachment 332956 [details] [review] Patch to add webp file format support to gimp master. Co-authored with Nathan Osman, this patch adds full webp file support including animations, icc profiles, exif, and xmp data. Adds optional switch for autogen.sh/configure scripts during configuration. Requires v0.5.1 libwepb, libwepbmux, and libwepbdemux (all from the libwebp package) for animation support.
Holy shit, thanks :)
I'm currently working with Robin Mills from exiv2 project to add the backend code to exiv2 to support the exif/xmp data stuff.
Pushed to master, with some cleanups like POTFILES.in, .gitignore and the usual coding style paranoia changes. Do you want to track further stuff here or can this bug be closed? commit c1021a3e3a8d4574505c8008ea619018a8fb1b69 Author: Benoit Touchette <draekko.software+gimp@gmail.com> Date: Mon Aug 8 16:39:30 2016 -0400 Bug 769651 - Add webp file format support to gimp master Patch to add webp file format support. Includes supports for loading/saving, icc profiles, exif, and xmp data. Co-authored with Nathan Osman. configure.ac | 37 +++ plug-ins/Makefile.am | 5 + plug-ins/file-webp/.gitignore | 7 + plug-ins/file-webp/Makefile.am | 64 ++++++ plug-ins/file-webp/file-webp-dialog.c | 287 ++++++++++++++++++++++++ plug-ins/file-webp/file-webp-dialog.h | 34 +++ plug-ins/file-webp/file-webp-load.c | 275 +++++++++++++++++++++++ plug-ins/file-webp/file-webp-load.h | 31 +++ plug-ins/file-webp/file-webp-save.c | 619 +++++++++++++++++++++++++++++++++++++++++++++++++++ plug-ins/file-webp/file-webp-save.h | 46 ++++ plug-ins/file-webp/file-webp.c | 270 ++++++++++++++++++++++ plug-ins/file-webp/file-webp.h | 28 +++ po-plug-ins/POTFILES.in | 4 + 13 files changed, 1707 insertions(+)
Yeah i know, i tried to get it to 90% but there's always so many tiny details for something like this some of it slips by, coding style is gnu, 2 char tab (spaces) and 80 width if i remember corrrectly, at any rate it's what i set my code beautifier to do. As for this bug it's fine, it can be closed. I figured someone will ring me up if there's any questions. Nathan will be glad lol.
Thanks :) closing.
I added Nathan Osman to the contributor's list. commit 8d78a9ad9f1661245d79bcc9490a7b561b8d9580 Author: Jehan <jehan@girinstud.io> Date: Wed Aug 10 15:12:23 2016 +0200 authors.xml: adding Nathan Osman. Commit c1021a3 was co-authored.
That's awesome! Thanks for doing this. Tracked few bugs on top of this one, with proposed patches: -> https://bugzilla.gnome.org/show_bug.cgi?id=769960 -> https://bugzilla.gnome.org/show_bug.cgi?id=769959
Semi-related... so I am replying here, animated webp images seem to be exported backwards (animates from top layer to bottom) ... perhaps someone else here can have look into this? https://bugzilla.gnome.org/show_bug.cgi?id=773449
patch uploaded on bug 773449. Thanks for spotting this (and, my bad for letting this slip!).