GNOME Bugzilla – Bug 763753
valve: don't send sticky events as a direct response to upstream events
Last modified: 2016-03-25 10:08:32 UTC
Created attachment 324103 [details] [review] test and fix Also refactor the existing valve test to actually test the valve, and not just test the EOS mechanism of a pad.
commit 1bc8d9f2ea90c01aaaae5efd90a2c1819f6aa98b Author: Havard Graff <havard.graff@gmail.com> Date: Wed Mar 16 15:13:39 2016 +0100 valve: don't send sticky events as a direct response to upstream events Also refactor the existing valve test to actually test the valve, and not just test the EOS mechanism of a pad. https://bugzilla.gnome.org/show_bug.cgi?id=763753
The unit test doesn't pass for me after this commit: $ make elements/valve.check-norepeat Running suite(s): valve Unexpected critical/warning: gstpad.c:4400:gst_pad_push_data:<'':src> Got data flow before segment event 50%: Checks: 2, Failures: 1, Errors: 0 gstcheck.c:79:F:valve_basic:test_valve_basic:0: Unexpected critical/warning: gstpad.c:4400:gst_pad_push_data:<'':src> Got data flow before segment event
commit d9a1cb21e41744d114667d3328dfaa5f85fbaa4b Author: Sebastian Dröge <sebastian@centricular.com> Date: Fri Mar 25 12:05:41 2016 +0200 valve: Fix unit test by sending caps before buffers Unexpected critical/warning: gstpad.c:4400:gst_pad_push_data:<'':src> Got data flow before segment event https://bugzilla.gnome.org/show_bug.cgi?id=763753