After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761820 - configure doesn't fail if libsoup not available
configure doesn't fail if libsoup not available
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2016-02-10 12:06 UTC by Alastair Porter
Modified: 2016-03-02 11:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
vala: Move variable assignments outside the conditional (2.40 KB, patch)
2016-03-02 11:09 UTC, Bastien Nocera
committed Details | Review
vala: Fix compilation with Vala enabled and grlnet disabled (1.33 KB, patch)
2016-03-02 11:09 UTC, Bastien Nocera
committed Details | Review

Description Alastair Porter 2016-02-10 12:06:35 UTC
Perhaps related to https://bugzilla.gnome.org/show_bug.cgi?id=743316

When compiling latest git master, I get a failure on make:

make[3]: Entering directory '/grilo/bindings/vala'
 VAPIGEN grilo-0.3.vapi
make[3]: *** No rule to make target '../../libs/net/GrlNet-0.3.gir', needed by 'grilo-net-0.3.vapi'.  Stop.
make[3]: Leaving directory '/grilo/bindings/vala'
Makefile:410: recipe for target 'all-recursive' failed


I see that GrlNet-0.3.gir is a valid target in libs/net/Makefile, however if I try and run make in this directory I get:

/grilo/libs/net$ make
  CC       libgrlnet_0.3_la-grl-net-mock.lo
grl-net-mock.c:31:26: fatal error: libsoup/soup.h: No such file or directory
compilation terminated.
Makefile:567: recipe for target 'libgrlnet_0.3_la-grl-net-mock.lo' failed


If I install libsoup headers, it successfully compiles.
Comment 1 Bastien Nocera 2016-03-02 11:09:42 UTC
Created attachment 322839 [details] [review]
vala: Move variable assignments outside the conditional

Otherwise EXTRA_DIST and co. aren't actually getting set if we're not
compiling with Vala.
Comment 2 Bastien Nocera 2016-03-02 11:09:46 UTC
Created attachment 322840 [details] [review]
vala: Fix compilation with Vala enabled and grlnet disabled
Comment 3 Bastien Nocera 2016-03-02 11:11:14 UTC
Attachment 322839 [details] pushed as 52a23f1 - vala: Move variable assignments outside the conditional
Attachment 322840 [details] pushed as a4b13a1 - vala: Fix compilation with Vala enabled and grlnet disabled