After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 761204 - Grammar errors in strings
Grammar errors in strings
Status: RESOLVED FIXED
Product: gxml
Classification: Other
Component: general
unspecified
Other Linux
: Normal minor
: ---
Assigned To: GXml maintainer(s)
GXml maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-01-27 20:08 UTC by Anders Jonsson
Modified: 2016-03-29 07:58 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Anders Jonsson 2016-01-27 20:08:50 UTC
Hi,
I saw two things in the strings for gxml:


#: ../gxml/Enumeration.vala:129
msgid "text can not been parsed to enumeration type:"


This should either be "text can not be" or possibly "text has not been"


#: ../gxml/SerializableObjectModel.vala:297
#, c-format
msgid "WARNING: Object type '%s' have no Node Name defined"

"Object type" is singular, so I think it should be "has" rather than "have".
Comment 1 Anders Jonsson 2016-02-23 22:35:38 UTC
Found two more strange strings:

>"File doesn't exists"

This should be "File doesn't exist" to be grammatically correct.


>"Node tried to interact with different document it belongs to"

This I had harder to parse. Is it "Node tried to interact with a different document than the one it belongs to" that is the intended meaning?
Comment 2 Anders Jonsson 2016-03-28 23:33:33 UTC
One more grammar issue added in gxml/TDocument.vala:
"Document have more than one root GXmlElement. Using first found"

Document is singular case, so "have" -> "has" here as well.

CC:ing author of Commit a53859b73ae5ea241ccad9302b56a518fee5ff8e
Comment 3 Anders Jonsson 2016-03-28 23:44:23 UTC
(In reply to Anders Jonsson from comment #2)
> CC:ing author of Commit a53859b73ae5ea241ccad9302b56a518fee5ff8e

Wrong commit, was really 2a5d8347f15c9f69905c963cde3d3c413242b542 by same author.
Comment 4 Daniel Espinosa 2016-03-29 00:44:05 UTC
Fixed on commits:

https://git.gnome.org/browse/gxml/commit/?id=020151bf595aaf2e5923848c8ad7ad62e9bce330

and

https://git.gnome.org/browse/gxml/commit/?id=5b0c330daecef2771a9061b3f7d3c05e5e8266b6

Please feel free to close this bug when you consider necessary or no more grammar errors are present.

Many thanks for your reports.
Comment 5 Anders Jonsson 2016-03-29 07:58:31 UTC
(In reply to Daniel Espinosa from comment #4)
> Please feel free to close this bug when you consider necessary or no more
> grammar errors are present.

Looks good now. Thanks for the fixes!

Regards,
Anders