After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 760056 - Add tests for hidden fundamental classes
Add tests for hidden fundamental classes
Status: RESOLVED OBSOLETE
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks: 760057
 
 
Reported: 2016-01-01 23:35 UTC by Lionel Landwerlin
Modified: 2018-02-08 12:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tests: Add a hidden fundamental class (2.48 KB, patch)
2016-01-01 23:35 UTC, Lionel Landwerlin 		committed Details | Review

Description Lionel Landwerlin 2016-01-01 23:35:21 UTC 
This is to provide a test case for a gjs crash.
Comment 1 Lionel Landwerlin 2016-01-01 23:35:30 UTC 
Created attachment 318141 [details] [review]
tests: Add a hidden fundamental class

We could have a fundamental type A derived by a subclass B. Class A happens
to be introspected, but B isn't. This can cause some issues in Gjs.
Comment 2 Philip Chimento 2017-01-14 07:35:11 UTC 
Review of attachment 318141 [details] [review]:

I forgot to comment on this one! In any case, I've had it in my tree for a while, and we landed the GJS patch, so let's land this one.
Comment 3 Lionel Landwerlin 2017-01-14 12:58:07 UTC 
Review of attachment 318141 [details] [review]:

Pushed to master.
Comment 4 Emmanuele Bassi (:ebassi) 2017-01-23 19:22:58 UTC 
This broke pygobject and anything that uses regress.c with compiler warnings enabled, because the get_type() function does not have a prototype — see bug 777484

What's the purpose of this test? Is the fundamental sub-type public? Should the get_type() function be visible?
Comment 5 Philip Chimento 2017-01-23 19:50:55 UTC 
The fundamental sub-type is not meant to be public, it's an analogy of ClutterRootNode or ClutterDummyNode according to Lionel's description in bug 760057.
Comment 6 GNOME Infrastructure Team 2018-02-08 12:40:58 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gobject-introspection/issues/154.