GNOME Bugzilla – Bug 757539
Add a help overlay for shortcuts
Last modified: 2021-07-05 11:31:51 UTC
Let's add a help overlay for shortcuts to play with the new GtkShortcutsWindow in gtk+.
Created attachment 314763 [details] [review] Add a help overlay for shortcuts
Created attachment 314764 [details] Screenshot
The inability to specify different shortcuts for LTR and RTL is an issue. See bug 757888
Created attachment 315409 [details] [review] Add a help overlay for shortcuts I was sloppy and hadn't 'git add'ed all the hunks.
Created attachment 315422 [details] [review] Added help overlay for shortcuts with the new GtkShortcutsWindow https://bugzilla.gnome.org/show_bug.cgi?id=757909
Sorry, Please remove the Patch "Added help overlay for shortcuts with the new GtkShortcutsWindow" submitted by me. I accidentally had this link open and submitted the bug number for this. Sorry once again.
Review of attachment 315409 [details] [review]: Looks good to me, thanks!
Created attachment 315680 [details] [review] Add a help overlay for shortcuts Resolve LTR vs RTL, and the help-overlay.ui to po/POTFILES.in
Comment on attachment 315680 [details] [review] Add a help overlay for shortcuts Pushed to master. Thanks, Cosimo.
Reopening. We need to add a "Keyboard Shortcuts" entry to the app-menu [1], and check the gestures supported by EvView and add them. [1] https://wiki.gnome.org/Initiatives/GnomeGoals/ShortcutWindows
Created attachment 315681 [details] [review] app-menu: Add "Keyboard Shortcuts" entry
Comment on attachment 315681 [details] [review] app-menu: Add "Keyboard Shortcuts" entry Pushed to master. The last remaining item is to add the gestures.
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new ticket at https://gitlab.gnome.org/GNOME/gnome-documents/-/issues/ Thank you for your understanding and your help.