GNOME Bugzilla – Bug 756573
pcapparse: Crash in presence of empty packet
Last modified: 2015-12-23 23:20:10 UTC
pcapparse does not handle packet without a payload size of 0, and crash. I cannot share the sample, but a simple code inspection is enough to see there is no protection against 0 payload packet. We should probably skip does packet. Meanwhile, I'm a bit suspicious, as for the same sample, I don't hit this situation with 1.4. So the payload size 0 might just be indicator of another regression. I'll try to see if I can free the sample meanwhile.
An empty buffer without content might be better than dropping.
commit c1494a558cada71c1318c160acaf819e3a82ac68 Author: Tim-Philipp Müller <tim@centricular.com> Date: Wed Dec 23 23:10:50 2015 +0000 tests: pcapparse: add check for 0-sized packets https://bugzilla.gnome.org/show_bug.cgi?id=756573 commit 9a20a7c77bd33b92bd195fc508fb566394c4dd11 Author: Tim-Philipp Müller <tim@centricular.com> Date: Wed Dec 23 20:24:46 2015 +0000 pcapparse: don't crash on 0-sized packets https://bugzilla.gnome.org/show_bug.cgi?id=756573
Created attachment 317831 [details] sample pcap with empty packets