Created attachment 314617 [details] [review]
Handle the 'geo' URI scheme

This will let Maps open the geo: URI scheme as
specified by RFC 5870.

In its simplest form it looks like:
    geo:latitude,longitude

An Android extension to set a description is also supported:
    geo:0,0?q=latitude,longitude(description)

Created attachment 314618 [details]
Cast of opening geo uri from firefox

Thanks for taking the time to report this.
This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find.

*** Bug 735215 has been marked as a duplicate of this bug. ***

I did not write that last part, a mistake most likely by me tho. This bug is open and alive.

Review of attachment 314617 [details] [review]:

Besides the philosophical comment, looks great :)

::: src/mapView.js
@@ +247,3 @@
+                              this._goToGeoURIInternal.bind(this, uri));
+        }
+        } catch(e) {

Just an idea, maybe for later, is it worth to do the realized check stuff inside Application.open method.

It's weird that the view needs to know when its realized within the MapView class for these two particular actions (open GeoURI, open GeoJSON), it looks like MapView knows details about the Application class. If the realized stuff occurs on the Application.open method, that method should be handle it, not every method called by open that intend to use the map view.

Created attachment 314645 [details] [review]
Add OpenStreetMaps URI to send-to-dialog

Created attachment 314646 [details]
Cast of opening OSM in browser from Maps

Created attachment 314649 [details] [review]
Add open with browser to send-to-dialog

This will add your default launcher for the
'https' URI scheme as an option to send-to-dialog.

Created attachment 314650 [details] [review]
Add open with browser to send-to-dialog

This will add your default launcher for the
'https' URI scheme as an option to send-to-dialog.

Created attachment 314652 [details]
Cast of opening OSM in browser from Maps

Review of attachment 314650 [details] [review]:

::: src/sendToDialog.js
@@ +47,3 @@
                         'clocksRow',
                         'clocksLabel',
+                        'osmRow',

I'd call it browser row, browser label, etc.

Created attachment 314657 [details] [review]
Add open with browser to send-to-dialog

This will add your default launcher for the
'https' URI scheme as an option to send-to-dialog.

Review of attachment 314650 [details] [review]:

::: src/sendToDialog.js
@@ +115,3 @@
+        let uriFormat = 'https://www.openstreetmap.org?lat=%f&lon=%f&zoom=%d';
+
+

You must use the place coordinates, not view.

Created attachment 314668 [details] [review]
Add open with browser to send-to-dialog

This will add your default launcher for the
'https' URI scheme as an option to send-to-dialog.

Created attachment 314669 [details]
Cast of opening OSM in browser from Maps

Review of attachment 314668 [details] [review]:

Looks great!

Attachment 314617 [details] pushed as 548128b - Handle the 'geo' URI scheme
Attachment 314668 [details] pushed as 687b3c1 - Add open with browser to send-to-dialog