GNOME Bugzilla – Bug 754744
Move keyboard focus to newly created folder
Last modified: 2021-06-18 15:53:54 UTC
After creating a new folder through the hamburger menu, the keyboard focus stays on the hamburger menu button, so you can't go to the newly created folder by simply pressing enter again. Using the context menu works fine, but that's often not available when using the list view.
Please update the Version to 3.22.x because the problem is still existing.
Forgot to add, that in the list view, a newly created directory through the hamburger menu looks like selected (blue color) but the focus is still on the hamburger menu. This is very confusing.
Created attachment 348293 [details] [review] Patch (In reply to Stefan from comment #2) > Forgot to add, that in the list view, a newly created directory through the > hamburger menu looks like selected (blue color) but the focus is still on > the hamburger menu. > This is very confusing. Hope now works ok. Regards!
Review of attachment 348293 [details] [review]: Yes excellent! We could do the same for every dialog, since we don't know where the focus would be. Something to think about... Just a nitpick: ::: src/nautilus-files-view.c @@ +2023,2 @@ g_clear_object (&priv->new_folder_controller); + gtk_widget_grab_focus (GTK_WIDGET (view)); Can you add a comment why we need to do this?
Created attachment 348526 [details] [review] Patch (In reply to Carlos Soriano from comment #4) > Can you add a comment why we need to do this? Sure!
Pushed with some changes to the wording, thanks!
(In reply to Stefan from comment #1) > Please update the Version to 3.22.x because the problem is still existing. AFAIK - but I welcome correction if I'm mistaken - the general policy is to leave the version at the value it had when the bug was originally reported, as a quick way to assess how long the bug has been around. Plus, it's really very impractical to imagine keeping all longstanding bugs' versions up-to-date constantly. :)
(In reply to Daniel Boles from comment #7) > (In reply to Stefan from comment #1) > > Please update the Version to 3.22.x because the problem is still existing. > > AFAIK - but I welcome correction if I'm mistaken - the general policy is to > leave the version at the value it had when the bug was originally reported, > as a quick way to assess how long the bug has been around. Plus, it's really > very impractical to imagine keeping all longstanding bugs' versions > up-to-date constantly. :) Not really, versions should be update to the latest one can reproduce, since we usually don't support older stable versions. In this way we can know if it's still happens or not, since the most common case is where bugs get invalid in some future versions but nobody goes to the old ones to test + close.
Oops, I must have been thinking of some other project. Thanks for the correction!
(In reply to Daniel Boles from comment #9) > Oops, I must have been thinking of some other project. Thanks for the > correction! Actually I'm almost sure this is for all GNOME projects. You can ask in #bugs for more info :)
Sure, I meant some other, non-GNOME project. For GNOME, I shall bump versions wherever I notice and can repro. :D
*** Bug 780921 has been marked as a duplicate of this bug. ***
The fix doesn’t seem to work here.
Due to how selection works (from set_selection), the keyboard focus isn’t moved, so grabbing focus of the container as in the patch doesn’t fully fix the problem. It only happens to work as expected if no item is selected or focused.
*** Bug 784401 has been marked as a duplicate of this bug. ***
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version of Files (nautilus), then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new ticket at https://gitlab.gnome.org/GNOME/nautilus/-/issues/ Thank you for your understanding and your help.