GNOME Bugzilla – Bug 753302
android: define NDK_VERSION for simple version setting
Last modified: 2016-07-01 09:54:15 UTC
It is very minor, but it could help make less diff when bumping up.
Created attachment 308826 [details] [review] android: define NDK_VERSION for simple version setting
Created attachment 308832 [details] [review] [1/2] add android_ndk_version property
Created attachment 308833 [details] [review] [2/2] bump up NDK version This is just an example. The compatibility r10e is not verified yet.
r10e compatibility is not there yet, see bug #750162. Must be fixed before 1.6 release, any help would be appreciated.
Comment on attachment 308832 [details] [review] [1/2] add android_ndk_version property I wouldn't make the NDK version configurable, but just put it into a variable in cerbero/bootstrap/android.py. Changing the NDK version usually requires more changes in various places, making it configurable via the config (and thus the user) is only going to cause problem and creates the illusion that you can just chose whatever NDK version you want.
> but just put it into a variable in cerbero/bootstrap/android.py. I've tried for the first time. my first obsolete patch has that modification. but, android.config also has revision info. in toolchain prefix. This patch is not serious. As a newbie for cerbero, grep is required to change NDK revision and I just think about avoiding that kind of situation again. :)
I would just put a > NDK_VERSION=r10d in android.config, and use that instead of having the r10d string in a few places.
Comment on attachment 308833 [details] [review] [2/2] bump up NDK version At least this one is obsolete, Cerbero now takes the latest r12 NDK
outdated.