After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 753138 - wayland: Invalidate our gtk_surface when we're unmapped
wayland: Invalidate our gtk_surface when we're unmapped
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Wayland
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-08-01 15:16 UTC by Rui Matos
Modified: 2015-08-03 12:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
wayland: Invalidate our gtk_surface when we're unmapped (875 bytes, patch)
2015-08-01 15:16 UTC, Rui Matos
none Details | Review
wayland: Ensure modal hint gets set on map (2.17 KB, patch)
2015-08-01 15:16 UTC, Rui Matos
committed Details | Review
wayland: Invalidate our gtk_surface when we're unmapped (1.01 KB, patch)
2015-08-03 11:53 UTC, Rui Matos
committed Details | Review

Description Rui Matos 2015-08-01 15:16:13 UTC
This should make modal dialogs actually be modal
Comment 1 Rui Matos 2015-08-01 15:16:17 UTC
Created attachment 308608 [details] [review]
wayland: Invalidate our gtk_surface when we're unmapped

Otherwise if we get mapped again we'll try to use an invalid
gtk_surface and the compositor will disconnect us.
Comment 2 Rui Matos 2015-08-01 15:16:23 UTC
Created attachment 308609 [details] [review]
wayland: Ensure modal hint gets set on map

We need to be mapped to have a gtk_surface and thus be able to do
requests on it so we need to save the modal hint and apply it when we
get mapped so that code that sets the hint before showing a window
doesn't get ignored.
Comment 3 Matthias Clasen 2015-08-01 18:14:05 UTC
Review of attachment 308608 [details] [review]:

::: gdk/wayland/gdkwindow-wayland.c
@@ +1351,2 @@
     }
 

Don't we have to call something like gtk_surface_destroy here ?
Comment 4 Matthias Clasen 2015-08-01 18:14:51 UTC
Review of attachment 308609 [details] [review]:

sure
Comment 5 Rui Matos 2015-08-03 11:53:51 UTC
Created attachment 308662 [details] [review]
wayland: Invalidate our gtk_surface when we're unmapped

--

(In reply to Matthias Clasen from comment #3)
> Don't we have to call something like gtk_surface_destroy here ?

Yes, of course.
Comment 6 Matthias Clasen 2015-08-03 12:17:37 UTC
Review of attachment 308662 [details] [review]:

looks good to me
Comment 7 Rui Matos 2015-08-03 12:31:18 UTC
Attachment 308609 [details] pushed as bd3b496 - wayland: Ensure modal hint gets set on map
Attachment 308662 [details] pushed as 3626307 - wayland: Invalidate our gtk_surface when we're unmapped