GNOME Bugzilla – Bug 749673
discoverer: Serialize the top level DiscovererInfo
Last modified: 2015-06-04 17:21:47 UTC
Which contains fields such as duration, uri and tags.
Created attachment 303738 [details] [review] discoverer: Serialize the top level DiscovererInfo
Comment on attachment 303738 [details] [review] discoverer: Serialize the top level DiscovererInfo Looks fine, sorry I missed that last time. Should we add a flag for serialising the URI as well?
(In reply to Tim-Philipp Müller from comment #2) > Comment on attachment 303738 [details] [review] [review] > discoverer: Serialize the top level DiscovererInfo > > Looks fine, sorry I missed that last time. > No problem, my mistake :) > Should we add a flag for serialising the URI as well? I don't think we want to have such a flag, your call though.
My rationale for the extra flag was that people may store the GVariant blob in a database and use the filename or URI as key, in which case you'd store it twice. But it can still be added later of course. Feel free to push.
Well, maybe one should make the uri a maybe-string then so we have the option in future.
Created attachment 304599 [details] [review] discoverer: Serialize the top level DiscovererInfo Which contains fields such as duration, uri and tags.
Review of attachment 303738 [details] [review]: commit decea41ac79de9928b96e74c627c74a3369c6160 Author: Mathieu Duponchelle <mathieu.duponchelle@opencreed.com> Date: Wed May 20 18:16:07 2015 +0200 discoverer: Serialize the top level DiscovererInfo Which contains fields such as duration, uri and tags. https://bugzilla.gnome.org/show_bug.cgi?id=749673 The uri is serialized as a maybe string, an extra flag can be added later if need be
Review of attachment 303738 [details] [review]: This commit was actually the previous one, rejected
Review of attachment 304599 [details] [review]: commit decea41ac79de9928b96e74c627c74a3369c6160 Author: Mathieu Duponchelle <mathieu.duponchelle@opencreed.com> Date: Wed May 20 18:16:07 2015 +0200 discoverer: Serialize the top level DiscovererInfo Which contains fields such as duration, uri and tags. https://bugzilla.gnome.org/show_bug.cgi?id=749673 The uri is serialized as a maybe string, an extra flag can be added later if need be