GNOME Bugzilla – Bug 747498
subparse : need_segment flag was set too early
Last modified: 2018-11-03 11:36:44 UTC
Created attachment 301118 [details] [review] set need_segment after sink pad received GST_EVENT_SEGMENT subparse works in push mode, chain funciton will be called once up stream element finished the seeking and flushing. if set need_segment flag in src pad event handler, the segment event will be pushed earlier, result in the subtitle text will be send out to down stream from the beginning. if the text sink (such as using appsink to catch text) don't compare the video timestamp with the received text timestamp, then the text and video will not sync.
*** Bug 661726 has been marked as a duplicate of this bug. ***
Created attachment 372211 [details] [review] subparse: set need_segment after sink pad received GST_EVENT_SEGMENT subparse works in push mode, chain funciton will be called once up stream element finished the seeking and flushing. if set need_segment flag in src pad event handler, the segment event will be pushed earlier, result in the subtitle text will be send out to down stream from the beginning. Upstream Status: Inappropriate [i.MX specific] Signed-off-by: Mingke Wang <mingke.wang@freescale.com>
Updated the patch against current master. Can someone knowledgeable about subparse check it ?
I don't really understand what this is trying to fix. What happens without the patch in what scenario, and what happens with the patch in the same scenario?
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/179.