After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 746802 - Zoom toggle button should zoom in and out when pressed
Zoom toggle button should zoom in and out when pressed
Status: RESOLVED OBSOLETE
Product: eog
Classification: Core
Component: general
3.14.x
Other Linux
: Normal normal
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-03-26 10:52 UTC by Allan Day
Modified: 2017-08-10 19:38 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Allan Day 2015-03-26 10:52:15 UTC
The redesign that landed in the 3.15.x uses a toggle button for zooming. The design was:

 * When pressed in, the zoom level should increase, and a slider should be displayed to fine tune.
 * When pressed out, the zoom level should return to its original state.

This behaviour is intended to allow a quick zoom in and out to check details in an image.

However, right now, the toggle button doesn't increase the zoom level when pressed. This means that the quick zoom in and out feature is lost. It also makes the toggle button feel unnecessary.

When I last discussed this with Felix, I suggested that pressing the button should increase the zoom level to 130% of the default zoom level.
Comment 1 Felix Riemann 2015-03-27 21:30:10 UTC
(In reply to Allan Day from comment #0)
> When I last discussed this with Felix, I suggested that pressing the button
> should increase the zoom level to 130% of the default zoom level.

Another idea I had, was to hook it up to the mechanics of the zoom in button from eog-3.14. That would make it zoom along a list of predefined zoom factors, ie. choose the next larger step in the list. If your image is at 100% it would zoom to 200% though at the moment.

The list: https://git.gnome.org/browse/eog/tree/src/eog-scroll-view.c#n2416
Comment 2 Felix Riemann 2015-05-25 17:17:13 UTC
I just pushed this, so we can hopefully receive some feedback.

commit 5bf0e3581e0b79ae217722f35d17f6021cc09871
Author: Felix Riemann <>
Date:   Mon May 25 19:12:23 2015 +0200

    Increase zoom level when toggling the zoom button
    
    Use the steps the zoom logic used in earlier eog versions.
    Also add a zoom level at 133% to not have the zoom jump
    to 200% when starting at 100% zoom.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=746802

This will make the zoom go to the next predefined zoom level that was used by the old zoom in toolbar buttons. I also added a zoom level of 133% to that list, as it would zoom to 200% if your window is large enough to show the image at 100%. This fealt like a very large jump to me.

I'll leave this open for feedback.
Comment 3 Allan Day 2015-05-28 10:33:23 UTC
I just tried master. One thing that seemed a bit odd - when you press the zoom button, the zoom level increases, but the slider is at it's lowest level. This means that it's not possible to zoom to the original level with the slider, or to zoom out further.
Comment 4 Felix Riemann 2015-06-15 17:25:50 UTC
Yeah, that's the other problem with the slider currently. We didn't make the whole zoom range available via the slider as it is linear and would make the lower zoom levels pretty hard to manage without making the slider pretty wide.
Comment 5 DF 2015-12-14 06:40:29 UTC
Ah that's why the slider only goes to 300. I posted to bug 757599 about the zoom slider. Could see how non-linear feels.

Also opened bug 759434 relating to lack of button to zoom to 100%. Toggling through different zooms would be more compact but I'd imagine having an array of buttons for 50,100,133,200% would be more streamlined. Or maybe have the toggle and have shortcuts to each level?
Comment 6 Felix Riemann 2017-08-10 19:38:32 UTC
This is obsolete now, as the zoom slider has been replaced by a text widget with separate buttons for zooming in and out.