GNOME Bugzilla – Bug 744307
Don't allow clicking location entry security indicator when location entry is not visible
Last modified: 2016-09-11 03:47:11 UTC
Created attachment 296556 [details] screenshot Don't allow clicking location entry security indicator when location entry is not visible. See the screenshot; this should not happen.
This also happens for the favicon: you can start a drag with the favicon even when the location entry is not visible, by correctly guessing its position underneath the title box!
I dosn't happen for me here.
Created attachment 319158 [details] screencast demonstrating issue
Created attachment 322433 [details] [review] title-box: Do not propagate button press events in title mode This is a speculative fix for the problem where clicking at just the right spot in the header bar opens the security popover via the security indicator in the hidden location entry. I haven't found any good way to reproduce this problem, unfortunately, but it happens regularly and I think there's a good chance this will fix it. This works because there's nothing inside the title box that users should be allowed to click on when in title mode, except for the security indicator, which is handled in this very function.
Comment on attachment 322433 [details] [review] title-box: Do not propagate button press events in title mode It makes sense, yes. Thanks!
Attachment 322433 [details] pushed as 25df867 - title-box: Do not propagate button press events in title mode
For the record, I've also sometimes accidentally dragged the favicon out of the title box when in title mode, though that is harder. Almost never have I been able to reproduce any of this intentionally, so I can only hope it's fixed.
Didn't work :(