GNOME Bugzilla – Bug 742966
validate: launcher: Fix test log header output
Last modified: 2015-06-24 14:44:12 UTC
Currently gst-validate-launcher writes headers to the log files after the tests have already run, thus overwriting the beginning of the file. Attached patch writes the header before running the tests.
Created attachment 294590 [details] [review] validate: launcher: Fix test log header output
Review of attachment 294590 [details] [review]: ::: validate/launcher/baseclasses.py @@ -276,3 @@ self.time_taken = time.time() - self._starting_time - if not self.reporter.uses_standard_output(): So you write it in stdout if it is what is used? (not a big deal anyway!)
Review of attachment 294590 [details] [review]: ::: validate/launcher/baseclasses.py @@ -276,3 @@ self.time_taken = time.time() - self._starting_time - if not self.reporter.uses_standard_output(): The place where this code is moved to is already protected with !stdout.
Review of attachment 294590 [details] [review]: ::: validate/launcher/baseclasses.py @@ -276,3 @@ self.time_taken = time.time() - self._starting_time - if not self.reporter.uses_standard_output(): Ah, ok
Created attachment 294693 [details] [review] validate: launcher: Fix test log header output Updated to apply cleanly after patches from #742973
Attachment 294693 [details] pushed as b29f378 - validate: launcher: Fix test log header output