GNOME Bugzilla – Bug 739305
souphttpsrc: log connection events at info level
Last modified: 2014-11-24 16:21:07 UTC
Soup connection events are non repeating. They get lost in noise at debug level. We carry on this patch, I believe it can be interesting to others.
I'm guessing you meant to attach a patch?
Created attachment 291099 [details] [review] 0001-souphttpsrc-log-connection-events-at-info-level.patch Patch working against 1.4.3 branch
Comment on attachment 291099 [details] [review] 0001-souphttpsrc-log-connection-events-at-info-level.patch >From bc1a515335d13a50ab98737ded8a9002aa53b87c Mon Sep 17 00:00:00 2001 >From: Branislav Katreniak <bkatreniak@nuvotechnologies.com> >Date: Tue, 25 Feb 2014 13:28:06 +0100 >Subject: [PATCH 1/2] souphttpsrc: log connection events at info level > >These events are non repeating. They get lost at debug level. > While I agree these belong to the INFO category rather than the DEBUG one, I don't understand your "non repeating" nor your "get lost". Can you elaborate and/or rephrase your commit message? > [..] >diff --git a/ext/soup/gstsouphttpsrc.c b/ext/soup/gstsouphttpsrc.c >index ad87223..db3b594 100644 >--- a/ext/soup/gstsouphttpsrc.c >+++ b/ext/soup/gstsouphttpsrc.c >@@ -1265,7 +1265,8 @@ gst_soup_http_src_finished_cb (SoupMessage * msg, GstSoupHTTPSrc * src) > GST_DEBUG_OBJECT (src, "finished, but not for current message"); > return; > } >- GST_DEBUG_OBJECT (src, "finished"); >+ GST_INFO_OBJECT (src, "finished, session_io_status:%d", >+ src->session_io_status); Add a space after ":" as it's done in the rest of the code. Looks good otherwise. Thanks.
Created attachment 291146 [details] [review] 0001-souphttpsrc-log-connection-events-at-info-level.patch Comments addressed: * non-sense text from git message removed * added space after : in io_status log message Additional changes compared to previos patch: * EOS message stays at DEBUG. It is not really connection related. * CANCEL is logged at INFO. Looking at the code, nothing would be logged at INFO.
Thanks, pushed: commit 1e03ffb820a736c073391eed242b59e790e4d1ec Author: Branislav Katreniak <bkatreniak@nuvotechnologies.com> Date: Fri Nov 21 11:21:18 2014 +0100 souphttpsrc: log connection events at info level https://bugzilla.gnome.org/show_bug.cgi?id=739305 (shortened the io status line a little)
(Didn't notice the ASSIGNED until after I'd pushed it, sorry)
It's OK. Thanks for taking care of it ;)