After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 738722 - rtpmux returns EMPTY caps when query'ing
rtpmux returns EMPTY caps when query'ing
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 1.4.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-10-17 20:53 UTC by Sjoerd Simons
Modified: 2014-10-24 19:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (1.77 KB, patch)
2014-10-17 20:53 UTC, Sjoerd Simons
committed Details | Review

Description Sjoerd Simons 2014-10-17 20:53:22 UTC
Created attachment 288788 [details] [review]
Proposed patch

When XMPP calls with empathy outgoing audio calls fail due to nicesink failing to be linked to the rtp muxer as it returns EMPTY when querying caps as it tries to give the result of intersecting incompatible caps (dtmfsrc & the audio stream)
Comment 1 Olivier Crête 2014-10-19 02:44:42 UTC
Review of attachment 288788 [details] [review]:

Looks good, also it should probably go into the 1.4 branch
Comment 2 Sebastian Dröge (slomo) 2014-10-21 08:52:42 UTC
commit 0ee384b251ae6ee4ac18210f3a0555898543de5f
Author: Sjoerd Simons <sjoerd@luon.net>
Date:   Fri Oct 17 22:23:27 2014 +0200

    rtpmux: Don't set PROXY_CAPS flag on the src pad
    
    rtpmux behaves like a funnel in that it forwards whatever upstream is
    sending buffers. So setting proxy caps doesn't make sense as the
    upstream don't have to have compatible caps, thus resulting in an empty
    caps set as a result of a caps query. Instead set fixed caps just
    as funnel does.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=738722
Comment 3 Tim-Philipp Müller 2014-10-24 19:55:45 UTC
Cherry-picked into 1.4 branch as well.