After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 738503 - Thumbnailing videos on an MTP camera (gvfs gphoto2) causes full video transfer
Thumbnailing videos on an MTP camera (gvfs gphoto2) causes full video transfer
Status: RESOLVED FIXED
Product: gnome-desktop
Classification: Core
Component: Thumbnail
3.15.x
Other Linux
: Normal normal
: ---
Assigned To: Desktop Maintainers
Desktop Maintainers
Depends on: 768064
Blocks:
 
 
Reported: 2014-10-14 03:50 UTC by Daniel Gnoutcheff
Modified: 2016-12-13 11:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
thumbnail-look-for-preview-icon-first.patch (9.07 KB, patch)
2014-10-14 03:52 UTC, Daniel Gnoutcheff
none Details | Review
thumbnailer: Always prefer the backend provided preview (3.07 KB, patch)
2016-06-26 12:18 UTC, Bastien Nocera
committed Details | Review

Description Daniel Gnoutcheff 2014-10-14 03:50:52 UTC
Trying to generate a thumbnail of a video on an MTP camera (via the gvfs gphoto2 backend) while totem-video-thumbnailer is installed causes the camera to transmit the entire video, during which time all other camera-related operations are also blocked.
Comment 1 Daniel Gnoutcheff 2014-10-14 03:52:36 UTC
Created attachment 288432 [details] [review]
thumbnail-look-for-preview-icon-first.patch
Comment 2 Bastien Nocera 2014-10-14 07:33:16 UTC
I think that instead of doing this in gnome-desktop, you should do this in the calling application, I'm guessing nautilus here.
Comment 3 Cosimo Cecchi 2015-02-06 00:47:00 UTC
I disagree - gnome-desktop already has logic that falls back to the preview icon attribute when the thumbnailer fails, like explained here.
Using it when available to bypass the external thumbnailer sounds like a policy that belongs in the library rather than in every client, since the file manager is not the only application that will read and request this.
Currently this attribute is only set by gvfs, so I think the proposed patch is ultimately reasonable; alternatively you should make the totem thumbnailer fail when it detects it's on MTP to trigger the existing fallback logic.
Comment 4 Pierre Ossman 2016-04-29 07:06:23 UTC
So what is the status here? This is still a major issue in Gnome 3.18. The gphoto2 gvfs backend is pretty much useless right now.

(I also notice that my nautilus is configured to only do thumbnails of files < 10 MiB, yet it is still trying to process my 2 GiB files)
Comment 5 Ondrej Holy 2016-05-04 14:03:53 UTC
I pushed patch for gphoto2 backend to change G_FILESYSTEM_PREVIEW_TYPE_IF_LOCAL to _NEVER (Bug 738503) and tries to convince Nautilus to use preview icons provided by the backend itself (Bug 765987).
Comment 6 Bastien Nocera 2016-06-26 12:18:48 UTC
Created attachment 330400 [details] [review]
thumbnailer: Always prefer the backend provided preview

If a preview exists for a particular file, in particular a preview icon
for videos and images on external devices, prefer those to running a
script.
Comment 7 Matthias Clasen 2016-07-01 14:22:14 UTC
Review of attachment 330400 [details] [review]:

Looks good to me, fwiw
Comment 8 Bastien Nocera 2016-12-13 11:20:05 UTC
Attachment 330400 [details] pushed as 370b985 - thumbnailer: Always prefer the backend provided preview