GNOME Bugzilla – Bug 737844
sync pull API should not iterate main context
Last modified: 2018-08-17 18:58:53 UTC
See https://bugzilla.redhat.com/show_bug.cgi?id=1148975
Created attachment 289385 [details] [review] libostree: Add ostree_repo_pull_with_options() We potentially need a lot of argument types for pull. Rather than have a C function with tons of arguments, let's use a GVariant a{sv} as a handy extensible (and immutable) bag of properties. This is prepratory work for adding an option to pull to traverse history. The first additional flag here is inherit-maincontext, which is used to fix
This unfortunately breaks the OstreeAsyncProgress API. I think to make this work sanely, we need to make ostree_repo_pull_with_options_async(). Or alternatively, if you pass an OstreeAsyncProgress to a synchronous pull API, we ignore the default main context for the AsyncProgress, and use the one allocated for the pull?
Review of attachment 289385 [details] [review]: I pushed a variant of this wish does NOT by default create a new main context.
OSTree has moved to Github a while ago. Furthermore, GNOME Bugzilla will be shut down and replaced by gitlab.gnome.org. If the problem reported in this Bugzilla ticket is still valid, please report it to https://github.com/ostreedev/ostree/issues instead. Thank you! Closing this report as WONTFIX as part of Bugzilla Housekeeping.