GNOME Bugzilla – Bug 735540
Remove Close from window menu
Last modified: 2016-09-22 22:43:00 UTC
Remove it from the menu, but keep the action around so that the accelerator still works.
Created attachment 284628 [details] [review] Remove Close from window menu "Header bar menus shouldn't include a close menu item, since this action is already provided by the header bar. It can also be ambiguous as to what a close menu item refers to." -- new HIG
Review of attachment 284628 [details] [review]: The close button in the header bar is to close the window, while the close action of the gear menu is to close the current tab, so they are not equivalent. ::: src/resources/epiphany-ui.xml @@ -46,3 @@ <menuitem name="HelpContentsMenu" action="HelpContents"/> <menuitem name="HelpAboutMenu" action="HelpAbout"/> - <menuitem name="FileCloseWindowMenu" action="FileCloseTab"/> I agree it's quite confusing having a menu item called FileCloseWindowMenu when its action is FileCloseTab
Well we could rename it to Close Tab but I would still rather remove it; there are close buttons on each tab, so who would open the hamburger menu to close a tab? There's also no space for it in a popover-style menu. OTOH we could leave it be for now and remove it when switching to a popover menu.