GNOME Bugzilla – Bug 734722
Adding of Place Icons
Last modified: 2018-03-26 12:41:13 UTC
The patch is w.r.t bug #730896. Geocode-glib maybe planning to deprecate their get_icon method and remove the poi icons. In my POI patches also I am using the same set of maki (https://github.com/mapbox/maki) icons (even more) as is currently used by geocode-glib. The location of these icons also needs to be decided. From What I asked at IRC and according to https://wiki.gnome.org/HowDoI/ThemedIcons , icons should be installed at "$(DESTDIR)$(datadir)/icons/hicolor/scalable/places/poi-XXX.svg". In the above case, if a library (geocode-glib) installs the icons to the same location and later uninstalls it, the maps won't be able to access it. But, If geocode-glib is removing icons, we may not need worry :). Or if we install to "$(DESTDIR)$(datadir)/icons/hicolor/scalable/places/gnome-maps-poi-xxx.svg" this might be a safe bet. Opinions ??
Created attachment 283829 [details] [review] Add base maki icons. In this patch the icons are installed to $(DESTDIR)$(datadir)/icons/gnome/scalable/places/poi-xxx.svg; If there is a collision with the Geocode Icons, we may change the location or change the name of the icon ('gnome-maps' as prefix).
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-maps/issues/13.