Created attachment 278536 [details] [review]
background: Use higher resolution thumbnails on HiDpi displays

Tested on gnome-3-12 because I don't have a full development environment set up on this machine, yet. But it applies against master too.

Review of attachment 278536 [details] [review]:

I'd rather this was all done piecemeal.

::: panels/background/bg-colors-source.c
@@ -34,3 @@
 
-static void
-bg_colors_source_class_init (BgColorsSourceClass *klass)

Move this in a separate commit.

::: panels/background/bg-wallpapers-source.c
@@ -43,2 @@
 static void
-bg_wallpapers_source_get_property (GObject    *object,

Remove this...

@@ -55,3 @@
-
-static void
-bg_wallpapers_source_set_property (GObject      *object,

...and this in a separate commit.

@@ -79,3 @@
-
-static void
-bg_wallpapers_source_class_init (BgWallpapersSourceClass *klass)

Ditto about moving the functions.

::: panels/background/cc-background-chooser-dialog.c
@@ +448,2 @@
   object_class = G_OBJECT_CLASS (klass);
+  object_class->constructed = cc_background_chooser_dialog_constructed;

You don't need to use constructed here, the dialog doesn't have any properties, so the state after init will be the same as after constructed.

(In reply to comment #2)
> Review of attachment 278536 [details] [review]:

Thanks for the review, Bastien.

> ::: panels/background/bg-colors-source.c
> @@ -34,3 @@
> 
> -static void
> -bg_colors_source_class_init (BgColorsSourceClass *klass)
> 
> Move this in a separate commit.

Done.

> ::: panels/background/bg-wallpapers-source.c
> @@ -43,2 @@
>  static void
> -bg_wallpapers_source_get_property (GObject    *object,
> 
> Remove this...
> 
> @@ -55,3 @@
> -
> -static void
> -bg_wallpapers_source_set_property (GObject      *object,
> 
> ...and this in a separate commit.

Done.

> @@ -79,3 @@
> -
> -static void
> -bg_wallpapers_source_class_init (BgWallpapersSourceClass *klass)
> 
> Ditto about moving the functions.

Done.

> ::: panels/background/cc-background-chooser-dialog.c
> @@ +448,2 @@
>    object_class = G_OBJECT_CLASS (klass);
> +  object_class->constructed = cc_background_chooser_dialog_constructed;
> 
> You don't need to use constructed here, the dialog doesn't have any properties,
> so the state after init will be the same as after constructed.

Oops, yes, you are right.

Created attachment 278586 [details] [review]
background: Remove empty property getters and setters

Created attachment 278587 [details] [review]
background: Rearrange the GObject boilerplate

Created attachment 278588 [details] [review]
background: Use higher resolution thumbnails on HiDpi displays

Created attachment 278589 [details] [review]
background: Remove unnecessary initialization

Review of attachment 278586 [details] [review]:

++

Review of attachment 278587 [details] [review]:

Looks good

Review of attachment 278588 [details] [review]:

Looks good

Review of attachment 278589 [details] [review]:

++

Thanks for the reviews, Bastien.