GNOME Bugzilla – Bug 730893
Dialogs use headerbars even when DialogsUseHeader is unset
Last modified: 2014-10-18 20:57:37 UTC
Right now, dialogs always use header bars and the Gtk/DialogsUseHeader setting only controls whether the buttons are in the action area or the header bar. I'm unaware of a desktop environment that wants header bar with buttons in the action area. The attached patches change this to use traditional title bars when DialogsUseHeader is not set.
Created attachment 277398 [details] [review] gtkdialog: don't use csd when use-header-bar is FALSE
Created attachment 277399 [details] [review] gtkaboutdialog: support showing buttons in action area Give GtkAboutDialog buttons in the action area instead of hard-coding use-header-bar to TRUE. This is for environments which don't have the Gtk/DialogsUseHeader xsetting turned on.
The setting is documented as: * This setting does not affect custom dialogs using GtkDialog * directly, or message dialogs.
(In reply to comment #3) > The setting is documented as: > > * This setting does not affect custom dialogs using GtkDialog > * directly, or message dialogs. How do the proposed patches break this?
Created attachment 278320 [details] [review] gtkdialog: don't use csd when use-header-bar is FALSE Fix a11y test.
Review of attachment 277399 [details] [review]: this one is fine with me.
Review of attachment 278320 [details] [review]: This one doesn't apply anymore. After manually applying it, I have one complaint: it breaks the nice rounded top of message dialogs, by giving them a server-side titlebar even under gnome-shell.
Comment on attachment 277399 [details] [review] gtkaboutdialog: support showing buttons in action area Attachment 277399 [details] pushed as b6c4865 - gtkaboutdialog: support showing buttons in action area
pushed with a fixup for message dialogs
Created attachment 288710 [details] [review] Mark strings as translatable
The buttons shown in the GtkAboutDialog aren't translatable anymore since this commit. Attached is a patch which fixes this. Please backport this also to 3.14. Thanks.
Review of attachment 288710 [details] [review]: yes
Could you commit the patch? I don't have commit access.
Comment on attachment 288710 [details] [review] Mark strings as translatable Committed the patch after being poked on IRC.