After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 728913 - Show contents from DMSes
Show contents from DMSes
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
3.12.x
Other All
: Normal enhancement
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
Depends on: 728912 731856
Blocks: 690256
 
 
Reported: 2014-04-24 21:39 UTC by Pranav Kant
Modified: 2017-09-27 07:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Added MediaServer Item extension (10.19 KB, patch)
2014-07-04 09:46 UTC, Pranav Kant 		needs-work Details | Review
Added MediaServer Item extension (10.02 KB, patch)
2014-08-19 19:45 UTC, Pranav Kant 		committed Details | Review
application: Invoke the media server miner to refresh the cache (2.49 KB, patch)
2014-09-05 13:46 UTC, Debarshi Ray 		committed Details | Review

Description Pranav Kant 2014-04-24 21:39:24 UTC 
By using the miner in Bug 728912 show the contents of the DMSes in gnome-photos application.
Comment 1 Pranav Kant 2014-07-04 09:46:47 UTC 
Created attachment 279889 [details] [review]
Added MediaServer Item extension
Comment 2 Debarshi Ray 2014-08-18 06:36:51 UTC 
Review of attachment 279889 [details] [review]:

Thanks for the fantastic patch, Pranav. A few superficial comments.

::: src/photos-media-server-item.c
@@ +1,3 @@
+/*
+ * Photos - access, organize and share your photos on GNOME
+ * Copyright © 2013, 2014 Red Hat, Inc.

This is obviously wrong. :)

@@ +32,3 @@
+#include <glib/gi18n.h>
+#include <goa/goa.h>
+#include <grilo.h>

We are not using this header.
Comment 3 Pranav Kant 2014-08-19 19:45:33 UTC 
Created attachment 283922 [details] [review]
Added MediaServer Item extension
Comment 4 Debarshi Ray 2014-08-28 09:09:02 UTC 
Review of attachment 283922 [details] [review]:

Aren't we missing the bits to trigger the miner? Can we do something better than polling for DLNA?
Comment 5 Debarshi Ray 2014-09-05 13:46:59 UTC 
Created attachment 285497 [details] [review]
application: Invoke the media server miner to refresh the cache