GNOME Bugzilla – Bug 72802
Gnome-cd should be able to show remaining time.
Last modified: 2005-12-21 14:30:44 UTC
There should be a possibility to make gnome-cd show the remaining time of the track it is playing.
punting till 2.x
Created attachment 17156 [details] [review] Patch against CVS HEAD
Nice. Adding PATCH keyword and upping pri.
Reassigning to the maintainer alias. Features should wait until after September, though. :)
Ted, any chance you could look at this patch?
Looks good, will apply to 2.7.x after 2.6.x is branched off.
Comment on attachment 17156 [details] [review] Patch against CVS HEAD Marking 'commit after freeze' to make it easy to find after the branch.
I'm going to look at this patch, but I don't see why we need a *preference* for showing the remaining time, so I want to rip out that part.
Ok, I checked, and I definately don't want the patch in as-is. What I would like is that the time display (which currently does current/total) be switched to displaying remaining time, and back. Also, it should have a tooltip. But it should definately *not* be a gconf preference.
Comment on attachment 17156 [details] [review] Patch against CVS HEAD Marking as need-work after Thomas comments
Created attachment 37702 [details] [review] This is a modified patch ..
Hi, From the patch, it seems like you're acting on a click on the display, right? I like that, it's intuitive. However, as opposed to what Thomas says (sorry ;) ), I *do* think we need to store the setting in gconf. The reason for this is simple: I want the setting to be conserved when I restart the application. Currently, that's not the case. Thomas asked for a tooltip that shows the current mode (i.e. either 'Current time: %d.%02d' or 'Remaining time: %d.%02d'). I don't see that yet. Lastly, cosmetical, your indenting looks pretty bad in the first part of the patch, can you please fix that? Once that's taken care of, I'll happily apply it. Thakns for the work so far!
Created attachment 38999 [details] [review] This is a modified patch which creates a additional key "show-remaining-time" in Gconf and sets the tooltip text accordingly.
Nirmal told me the tooltip doesn't work, may be a bug in GtkDrawingArea. Will look at that.
(marking patch for owns sanity.)
Created attachment 45580 [details] [review] update So the previous patch didn't actually apply anymore, and clicking display didn't do anything, because the signal was unused. This patch fixes that. It also plug some memleaks introduced by the previous one. The tooltip is still TODO, btw, so the patch isn't finished yet.
*** Bug 310671 has been marked as a duplicate of this bug. ***
Created attachment 49674 [details] [review] Patch against the CVS HEAD Add events to Display to show tool tips. When the mouse is in the Display, the tooltip shows "CD Player". When it is playing, it shows time. But the tool tip is not displayed in the Display area, but below that.
Created attachment 49675 [details] snapshot,.. Couldnt take a clear one
2005-12-21 Madhan Raj M <madhanrm@cvs.gnome.org> Reviewed by: Ronald S. Bultje <rbultje@ronald.bitfreak.net> * gnome-cd/callbacks.c: (status_ok), (remainingtime_mode_changed_cb), (volume_changed): Set the tool tip for the display. * gnome-cd/callbacks.h: * gnome-cd/display.c: (button_press_event), (class_init) * gnome-cd/display.h: * gnome-cd/gnome-cd.c: (window_destroy_cb), (set_volue), (init_player) Add events to the display to show tool tip. * gnome-cd/gnome-cd.h: * gnome-cd/gnome-cd.schemas.in.in: * gnome-cd/preferences.c: Remaining time mode. Fixes Bug #72802.