GNOME Bugzilla – Bug 727774
[3.14] document removal of word-chars setting
Last modified: 2014-09-20 12:27:10 UTC
The 'word-chars' setting has been removed (it now always uses a more sensible but hardcoded set of characters).
I'll do it ~~
Created attachment 277041 [details] [review] Fix ^-^
(In reply to comment #0) > The 'word-chars' setting has been removed (it now always uses a more sensible > but hardcoded set of characters). Hi Christian, did you mean that the character encoding settings have changed, or some other setting?
This has nothing to do with encodings; this is (well, was) the setting that allowed you to specify a set of characters that control what's considered a 'word' when you double click in the terminal (double-clicking selects the word the mouse is over).
ZoeChang looked up the related code change in https://git.gnome.org/browse/gnome-terminal/commit/?id=e63cbcf64d2fde5bc4a8cb8ae0e3ef8c95a6d889 before creating this patch.
Review of attachment 277041 [details] [review]: ::: help/C/txt-select-text.page @@ +28,3 @@ <title>Text selection</title> + <p>You can define selection criteria for text in <app>Terminal</app>. From what I understand, it's no longer possible to define the selection criteria, so I think this sentence can be removed, no? @@ +31,1 @@ <p>Once you have set your selection preference, you can select text in In which case the first half of this sentence can be removed too…
Created attachment 277682 [details] Screenshots to compare As judgement is harder and confusion is bigger without screenshots, here's a comparison between old 3.10 and a freshly built 3.13.2. Hope that helps to get this going. :)
Looking at the screenshots, Kat is correct in comment 6 - need to remove more text. Our docs on https://wiki.gnome.org/Git/Developers don't explain how to rework a locally committed patch (which isn't pushed yet). :( My guess (my git skills are very basic and at work we use 'git-review', hence someone correct me please if I'm giving bad advice): Edit the help file again, then use git commit --amend help/C/txt-select-text.page (and potentially also git pull --rebase in case that git complains that things are not clean or cannot be done), followed by git format-patch HEAD^ again to create the diff file called something like 0001-something.diff, if I interpret https://wiki.gnome.org/Git/Developers#Contributing_patches correctly. Also see http://git-scm.com/book/en/Git-Basics-Undoing-Things for more info.
Hi Zoe, are you still working on this patch? It would be good if you could re-submit it this week. If you need help with git, please drop us an email or find us in #docs on IRC!
Comment on attachment 277041 [details] [review] Fix ^-^ Pushed to master in commit 44041a9477ee30c67fb8659befadee90de1b6af6 after a adding the last fix. Thanks for the patch!