After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 72723 - finish porting bookmarks window to treeview
finish porting bookmarks window to treeview
Status: RESOLVED INVALID
Product: nautilus
Classification: Core
Component: Bookmarks
0.x.x [obsolete]
Other other
: Normal normal
: future
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 84697 (view as bug list)
Depends on: 72043
Blocks:
 
 
Reported: 2002-02-26 20:57 UTC by jacob berkman
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
(incomplete) patch to port bookmark list to list store (30.01 KB, patch)
2002-02-26 20:58 UTC, jacob berkman 		none Details | Review

Description jacob berkman 2002-02-26 20:57:03 UTC 
the treeview DND code changes the ordering on the model, so the
GtkListStore gets out of sync with the fake model NautilusBookmarkList.

so, it makes sense to port NautilusBookmarkList to be a GtkListStore.

this patch does that, but there are still a few cases where GtkTreeView
will unselect a row and there will still be rows available, but not selected.

(plus any other bugs)
Comment 1 jacob berkman 2002-02-26 20:58:18 UTC 
Created attachment 6890 [details] [review]
(incomplete) patch to port bookmark list to list store
Comment 2 jacob berkman 2002-02-26 20:59:47 UTC 
adding a dependency on a bug that affects this report.
Comment 3 Dave Bordoley [Not Reading Bug Mail] 2002-06-07 07:29:26 UTC 
Can i basically assume that this has been fixed by now???
Comment 4 jacob berkman 2002-06-07 15:57:01 UTC 
it looks like it's working, but i don't know if anyone fixed it.
Comment 5 Luis Villa 2002-06-10 13:07:27 UTC 
This all got committed, I'm pretty sure. Closing.
Comment 6 Damon Chaplin 2002-06-11 20:35:45 UTC 
Ouch. This never got committed.

And I did a simpler hack to get DnD mostly working instead, knowing
nothing about this patch.

I'll reopen, mainly as the patch may be useful at some point.
I don't know if we want to do this for 2.0.1 though.
Comment 7 Damon Chaplin 2002-06-12 18:44:07 UTC 
Also see bug #84697. We only need to do one of these, and at this point
I'd go for 84697 as that needs only minor changes.
Comment 8 Luis Villa 2002-06-14 19:28:23 UTC 
Given that there is another solution for this, I'm bumping this and
moving it to future.
Comment 9 Damon Chaplin 2002-06-21 18:50:10 UTC 
*** Bug 84697 has been marked as a duplicate of this bug. ***
Comment 10 Kjartan Maraas 2003-10-30 21:17:47 UTC 
Is this stuff still relevant?
Comment 11 Alexander Larsson 2003-11-07 10:28:33 UTC 
Its looks relevant still from a quick glance.
Comment 12 Dave Camp 2004-05-05 22:31:34 UTC 
we need to rethink the bookmarks stuff, this won't be relevant