After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727035 - W32: Combobox button is drawn with two arrows
W32: Combobox button is drawn with two arrows
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Themes
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-03-25 17:27 UTC by LRN
Modified: 2014-04-04 10:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
W32: Fix double-arrowed combobox button (1.09 KB, patch)
2014-03-25 17:27 UTC, LRN
reviewed Details | Review
How it looks without the patch (3.13 KB, image/png)
2014-03-25 17:30 UTC, LRN
  Details
How it looks with the patch (2.82 KB, image/png)
2014-03-25 17:30 UTC, LRN
  Details
W32: Fix double-arrowed combobox button (v2) (2.02 KB, patch)
2014-03-26 06:44 UTC, LRN
none Details | Review
How it looks without the patch (17.41 KB, image/png)
2014-03-26 06:44 UTC, LRN
  Details
How it looks with the patch (16.70 KB, image/png)
2014-03-26 06:45 UTC, LRN
  Details
W32: Fix double-arrowed combobox button (v3) (2.99 KB, patch)
2014-03-28 05:50 UTC, LRN
committed Details | Review

Description LRN 2014-03-25 17:27:35 UTC
W32 theme part already draws an arrow as part of the background, and GTK draws
its own arrow on top of that.
Comment 1 LRN 2014-03-25 17:27:38 UTC
Created attachment 272876 [details] [review]
W32: Fix double-arrowed combobox button

The arrow is part of the background image drawn by the theme, don't draw
GTK's own arrow.
Comment 2 LRN 2014-03-25 17:30:27 UTC
Created attachment 272878 [details]
How it looks without the patch
Comment 3 LRN 2014-03-25 17:30:42 UTC
Created attachment 272879 [details]
How it looks with the patch
Comment 4 Emmanuele Bassi (:ebassi) 2014-03-25 17:38:46 UTC
Review of attachment 272876 [details] [review]:

I wonder if we support the "display:none" property; it would be slightly clearer than drawing with a transparent color.
Comment 5 LRN 2014-03-25 17:52:21 UTC
Theme parsing error: gtk.css:169:7: 'display' is not a valid property name
Comment 6 LRN 2014-03-26 06:14:10 UTC
No, this is wrong.

This patch removes the arrow from all comboboxes, but we only need to remove it from the ones that have "has-entry" set. Either that, or change how comboboxes without entry are drawn (right now it seems that GTK is mostly responsible for them).
Comment 7 LRN 2014-03-26 06:44:12 UTC
Created attachment 272961 [details] [review]
W32: Fix double-arrowed combobox button (v2)

The arrow is part of the background image drawn by the theme, don't draw
GTK's own arrow. This also applies to non-entry comboboxes.
Comment 8 LRN 2014-03-26 06:44:51 UTC
Created attachment 272962 [details]
How it looks without the patch
Comment 9 LRN 2014-03-26 06:45:13 UTC
Created attachment 272963 [details]
How it looks with the patch
Comment 10 LRN 2014-03-28 05:50:03 UTC
Created attachment 273132 [details] [review]
W32: Fix double-arrowed combobox button (v3)

The arrow is part of the background image drawn by the theme, don't draw
GTK's own arrow. This also applies to non-entry comboboxes.

On XP the arrow-and-nothing-else part does not exist (W32 XP theme draws a
white rectangle) and has to be subtituted for a simple dropdown button even
for non-entry comboboxes.
Comment 11 Ignacio Casal Quinteiro (nacho) 2014-04-01 10:28:59 UTC
Ok for me.
Comment 12 Matthias Clasen 2014-04-02 00:23:30 UTC
Review of attachment 273132 [details] [review]:

ok
Comment 13 LRN 2014-04-04 09:57:21 UTC
Attachment 273132 [details] pushed as 2b36054 - W32: Fix double-arrowed combobox button