After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 725985 - Update get-help.page according to UI change for 3.12
Update get-help.page according to UI change for 3.12
Status: RESOLVED FIXED
Product: gnome-mines
Classification: Applications
Component: documentation
git master
Other Linux
: Normal normal
: ---
Assigned To: Maintainers of Gnome user documentation
gnome-mines-maint
Depends on:
Blocks:
 
 
Reported: 2014-03-09 14:45 UTC by Rashi Aswani
Modified: 2014-03-23 22:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Updated get-help.page according to UI change for 3.12 (2.16 KB, patch)
2014-03-09 14:49 UTC, Rashi Aswani
none Details | Review
Updated get-help.page according to UI change for 3.12 (2.17 KB, patch)
2014-03-10 15:12 UTC, Rashi Aswani
none Details | Review
Updated get-help.page according to UI change for 3.12 (2.19 KB, patch)
2014-03-18 00:12 UTC, Rashi Aswani
needs-work Details | Review
Updated the penalty and string "Warn if too many flags are placed next to a number" in get-help.page. (2.56 KB, patch)
2014-03-23 22:34 UTC, Rashi Aswani
committed Details | Review

Description Rashi Aswani 2014-03-09 14:45:46 UTC
get-help.page needs to be updated according to the UI change.
Comment 1 Rashi Aswani 2014-03-09 14:49:18 UTC
Created attachment 271357 [details] [review]
Updated get-help.page according to UI change for 3.12
Comment 2 Michael Catanzaro 2014-03-09 16:54:25 UTC
Can you please also mention that the time penalty caps out at 60s?
Comment 3 Rashi Aswani 2014-03-09 22:19:29 UTC
Hi Michael, thanks for the indication, I checked the penalty time and it gets constant after reaching 90 seconds, can you please verify it?
Comment 4 Michael Catanzaro 2014-03-10 04:02:39 UTC
You're right, it is 90 seconds, my mistake!
Comment 5 André Klapper 2014-03-10 14:23:53 UTC
Comment on attachment 271357 [details] [review]
Updated get-help.page according to UI change for 3.12

>+  checkbox next to <gui>Warn if too many flags are  placed next to a

Small typo: There is a duplicated whitespace... :)
Comment 6 Rashi Aswani 2014-03-10 15:12:31 UTC
Created attachment 271436 [details] [review]
Updated get-help.page according to UI change for 3.12
Comment 7 André Klapper 2014-03-17 23:50:36 UTC
Comment on attachment 271436 [details] [review]
Updated get-help.page according to UI change for 3.12

>+  <p>Click <gui style="button">Receive a hint for your next move</gui> to

There's no button called like that, but there is a button which displays a question mark in a square. It does show the text mentioned above when hovering over with the mouse.

"Click the <gui style="button">question mark in a square</gui>" doesn't sound good either.

Hmm, hmm. I really don't know what's the best way to express that. :-/

>+  reveal a hidden tile that is safe. A penalty of ten seconds will be added
>+  to your total time. Penalty will be increased by ten progressively on
>+  subsequent hints till the ninth hint.</p>

The penalty was mentioned before, so you could say "The penalty will be increased".
Also, "by ten" what? Probably "by ten seconds"? :)
Comment 8 Rashi Aswani 2014-03-18 00:12:35 UTC
Created attachment 272213 [details] [review]
Updated get-help.page according to UI change for 3.12
Comment 9 Kat 2014-03-19 11:38:19 UTC
Review of attachment 272213 [details] [review]:

It is good practice to write a bit more detail into the commit message. For example, you may want to mention that the string in the preference dialog has changed and so has the main window.

::: help/C/get-help.page
@@ +33,3 @@
+  reveal a hidden tile that is safe. A penalty of ten seconds will be added
+  to your total time. The penalty will be increased by ten seconds
+  progressively on subsequent hints till the ninth hint.</p>

I think you should specify that it's a button which is being pressed and where it is in the UI (top right) because it isn't clear that it is a button.

ninth? Please spell check before submitting patches :)
Comment 10 Kat 2014-03-19 12:08:26 UTC
(In reply to comment #9) 
> ninth? Please spell check before submitting patches :)

ninth it is, my mistake!
Comment 11 Rashi Aswani 2014-03-23 22:34:34 UTC
Created attachment 272713 [details] [review]
Updated the penalty and string "Warn if too many flags are placed next to a number" in get-help.page. 

Updated the commit message and the button information.
Please review, thanks.
Comment 12 Kat 2014-03-23 22:47:54 UTC
Comment on attachment 272713 [details] [review]
Updated the penalty and string "Warn if too many flags are placed next to a number" in get-help.page. 

Pushed to master in commit 83d12b18547df68517390c23c06926f104ad1c81