After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723832 - Thumbnails film strip looks crude and is unnecessary
Thumbnails film strip looks crude and is unnecessary
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: general
3.11.x
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks: 723907
 
 
Reported: 2014-02-07 10:42 UTC by Allan Day
Modified: 2014-02-09 20:54 UTC
See Also:
GNOME target: ---
GNOME version: 3.11/3.12

Attachments
thumbnailer: Remove film strip from generated thumbnails (8.19 KB, patch)
2014-02-08 15:29 UTC, Bastien Nocera 		committed Details | Review

Description Allan Day 2014-02-07 10:42:53 UTC 
We know it's a video - we don't need the film strip. Also, they don't look very good.
Comment 2 Bastien Nocera 2014-02-07 17:07:13 UTC 
The way to fix this would be for nautilus to apply the film strip rather than the thumbnailer.
Comment 3 Bastien Nocera 2014-02-08 15:29:16 UTC 
Created attachment 268501 [details] [review]
thumbnailer: Remove film strip from generated thumbnails
Comment 4 Bastien Nocera 2014-02-08 23:46:18 UTC 
Attachment 268501 [details] pushed as dae3a26 - thumbnailer: Remove film strip from generated thumbnails
Comment 5 Philip Withnall 2014-02-09 18:03:02 UTC 
(In reply to comment #2)
> The way to fix this would be for nautilus to apply the film strip rather than
> the thumbnailer.

Would it be better to not remove the functionality entirely, but to hide it behind a command line option (--disable-film-strip) which is set by default in the .thumbnailer file? I wonder if removing the functionality entirely might make other users of totem-video-thumbnailer complain.
Comment 6 Bastien Nocera 2014-02-09 18:06:32 UTC 
(In reply to comment #5)
> (In reply to comment #2)
> > The way to fix this would be for nautilus to apply the film strip rather than
> > the thumbnailer.
> 
> Would it be better to not remove the functionality entirely, but to hide it
> behind a command line option (--disable-film-strip) which is set by default in
> the .thumbnailer file? I wonder if removing the functionality entirely might
> make other users of totem-video-thumbnailer complain.

Which other users?
Comment 7 Philip Withnall 2014-02-09 20:54:15 UTC 
(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #2)
> > > The way to fix this would be for nautilus to apply the film strip rather than
> > > the thumbnailer.
> > 
> > Would it be better to not remove the functionality entirely, but to hide it
> > behind a command line option (--disable-film-strip) which is set by default in
> > the .thumbnailer file? I wonder if removing the functionality entirely might
> > make other users of totem-video-thumbnailer complain.
> 
> Which other users?

I don’t know any, but totem-video-thumbnailer is a public API of sorts, and I can easily imagine it being used in various places (although potentially all through GnomeDesktopThumbnailFactory?).

Basically, I think the slight cost of keeping the code (with a command line option) is less than the cost of handling bug reports from angry users when they find the functionality’s disappeared.