After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722844 - gst-rtsp-server: Use atomic statistics property on basepayload to get rtpinfo
gst-rtsp-server: Use atomic statistics property on basepayload to get rtpinfo
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
git master
Other All
: Normal enhancement
: 1.2.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-01-23 16:50 UTC by Sebastian Rasmussen
Modified: 2014-02-25 22:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch using the newly introduced atomic rtpinfo property interface. (2.13 KB, patch)
2014-01-23 16:51 UTC, Sebastian Rasmussen 		committed Details | Review

Description Sebastian Rasmussen 2014-01-23 16:50:33 UTC 
Previously the "seqnum", "timestamp", "running-time" properties on the RTPBasePayload and "clock-rate" from GstCaps were fetched in sequence despite being assumed to all be synchronized with each other. There was no guarantee that this was actually the case.

With the newly introduced statistics property in https://bugzilla.gnome.org/show_bug.cgi?id=719415 we can now use this to retrieve all the rtpinfo data atomically. So the attached patch does exactly this.
Comment 1 Sebastian Rasmussen 2014-01-23 16:51:31 UTC 
Created attachment 267063 [details] [review]
Proposed patch using the newly introduced atomic rtpinfo property interface.
Comment 2 Wim Taymans 2014-01-28 13:53:55 UTC 
commit 036f2760bff796c2f70ca6efef2efac7ad954a14
Author: Wim Taymans <wtaymans@redhat.com>
Date:   Tue Jan 28 14:51:26 2014 +0100

    stream: don't leak stats structure
    
    Don't leak the stats structure and deal with NULL stats.

commit 7edaa6ca201c1fb2e03a0f6ddebd3642685935a6
Author: Sebastian Rasmussen <sebrn@axis.com>
Date:   Wed Jan 22 22:03:14 2014 +0100

    stream: Get rtpinfo properties atomically from payloader
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=722844