After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 721789 - can't press A or Delete to archive message
can't press A or Delete to archive message
Status: RESOLVED FIXED
Product: geary
Classification: Other
Component: ux
master
Other Linux
: High normal
: 0.6.0
Assigned To: Geary Maintainers
Geary Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-01-08 14:19 UTC by Adam Dingle
Modified: 2014-02-05 02:44 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Adam Dingle 2014-01-08 14:19:19 UTC
With recent changes I can no longer press A to archive a message.  Has this shortcut gone away?  (If so I will miss it, and also the help needs to be updated since it still lists this keyboard shortcut.)
Comment 1 Adam Dingle 2014-01-08 14:22:29 UTC
The Delete key won't archive a message any more either.
Comment 2 Adam Dingle 2014-01-08 14:35:51 UTC
Actually it appears there is now no working shortcut for archiving a message since Backspace currently deletes a message (see bug 721792).
Comment 3 Charles Lindsay 2014-01-08 19:12:43 UTC
Pressing Delete or Backspace should trash the message.  Pressing A should still archive a message.  When I press A, I get:

(geary:3148): Gdk-WARNING **: Event with type 8 not holding a GdkDevice. It is most likely synthesized outside Gdk/GTK+

Not sure what's going on there, but we should investigate and fix.
Comment 4 Jim Nelson 2014-01-08 19:45:40 UTC
The Event type 8 error was reported in bug #713240.  Eric investigated this some time ago, even digging into the GDK code.  The code generating the error is undocumented (as I recall) and we were a little mystified why it was generated or what it signified.  He asked a question about it on the GTK mailing list and received no response.

If my memory serves, this error message only occurred if using a hot key was the first Action invoked.  That is, once the user pressed a toolbar button, the GDK error would go away.  That doesn't seem to be the case with A any longer.

There's a slight change in the recent patch to how we handle keyboard events, primarily to detect when Shift is pressed to change the action/icon of the Trash button (similar to how we change the Rotate button in Shotwell).  I can't imagine how that would cause this problem, but perhaps that's one place to start looking.
Comment 5 Jim Nelson 2014-01-09 00:10:22 UTC
See note at bug #713240 for a development on this problem.  I was able to stop this warning from happening entirely by manually tweaking the GTK bindings and avoid copying the GdkEventKey.  However, the A accelerator still doesn't work; I don't know why.
Comment 6 Jim Nelson 2014-02-04 19:40:06 UTC
Jürg has a patched GDK bindings available at #713240 that stops the console warning.  However, even with that in place, our keyboard shortcuts aren't working.  We need to investigate now that we know for certain this isn't due to bindings.
Comment 7 Jim Nelson 2014-02-05 02:44:28 UTC
Pushed to master, commit 28c7eba1

Fix requires compilation with Vala 0.23.2 or better, but code will still compiles with older versions.