After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 720206 - Top bar - disclosure triangles aren't vertically centered
Top bar - disclosure triangles aren't vertically centered
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: system-status
3.11.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
3.12
Depends on:
Blocks:
 
 
Reported: 2013-12-10 17:58 UTC by Allan Day
Modified: 2014-02-19 14:29 UTC
See Also:
GNOME target: ---
GNOME version: 3.11/3.12


Attachments
modified screenshot (180.38 KB, image/png)
2013-12-10 17:58 UTC, Allan Day
  Details
popupMenu: Use an image for arrows (19.47 KB, patch)
2014-02-18 12:49 UTC, Carlos Soriano
none Details | Review
popupMenu: Use an image for arrows (8.07 KB, patch)
2014-02-18 14:51 UTC, Carlos Soriano
none Details | Review
popupMenu: Use relative rotation for arrows (1.65 KB, patch)
2014-02-18 14:51 UTC, Carlos Soriano
none Details | Review
popupMenu: Use an image for arrows (8.07 KB, patch)
2014-02-18 14:51 UTC, Carlos Soriano
none Details | Review
popupMenu: Use relative rotation for arrows (2.25 KB, patch)
2014-02-18 18:54 UTC, Carlos Soriano
none Details | Review
popupMenu: Use an image for arrows (8.77 KB, patch)
2014-02-18 18:54 UTC, Carlos Soriano
none Details | Review
popupMenu: Use relative rotation for arrows (2.25 KB, patch)
2014-02-18 19:03 UTC, Carlos Soriano
none Details | Review
popupMenu: Use an image for arrows (8.79 KB, patch)
2014-02-18 19:03 UTC, Carlos Soriano
none Details | Review
screenshot of the patches in action (195.15 KB, image/png)
2014-02-18 19:35 UTC, Allan Day
  Details
popupMenu: Rename _arrow_rotation to follow JS covention (2.43 KB, patch)
2014-02-19 14:27 UTC, Carlos Soriano
committed Details | Review
popupMenu: Use relative rotation for arrows (2.24 KB, patch)
2014-02-19 14:27 UTC, Carlos Soriano
committed Details | Review
popupMenu: Use an image for arrows (8.80 KB, patch)
2014-02-19 14:27 UTC, Carlos Soriano
committed Details | Review

Description Allan Day 2013-12-10 17:58:35 UTC
Created attachment 263937 [details]
modified screenshot

The disclosure triangles in the top bar look out of alignment with the icons in the system status area. I've attached a screenshot; the bottom image has been modified by moving the arrows up a couple of pixels.
Comment 1 Hashem Nasarat 2013-12-10 18:08:34 UTC
I think it looks better the way they are. With the current height they start at the middle ("vertically centered") and drop down. Perhaps we can ask one of the font experts around here...
Comment 2 Allan Day 2013-12-12 12:18:31 UTC
Centring usually refers to the visual "centre of gravity" - ie. the middle of the object. Maybe I'm wrong though. CC'ing Jakub for a second opinion.
Comment 3 Allan Day 2014-01-21 08:20:19 UTC
I also think that the arrows should be slightly larger; right now they look a little bit like an afterthought.
Comment 4 Jakub Steiner 2014-01-21 11:19:08 UTC
I think you went too far. Especially the text-only keyboard switcher now feels off balance to my eye. Going a 1px down would probably hit the sweet spot. 

I don't feel like enlarging would be a good thing either, unless we counter the increased weight with toning down the color.
Comment 5 Carlos Soriano 2014-02-06 15:03:03 UTC
FWIW, this is something neear for what Allan proposed. It is with ubuntu fonts:
http://i.imgur.com/vhXN7zG.png

But Allan propose to use an icon instead of rely on fonts for those. Can designers provide a svg for that with the desired size given a specific font size? (four arrow positions) and I will look into it this weekend. Thanks!
Comment 6 Allan Day 2014-02-06 21:48:24 UTC
(In reply to comment #5)
> FWIW, this is something neear for what Allan proposed. It is with ubuntu fonts:
> http://i.imgur.com/vhXN7zG.png
> 
> But Allan propose to use an icon instead of rely on fonts for those. Can
> designers provide a svg for that with the desired size given a specific font
> size? (four arrow positions) and I will look into it this weekend. Thanks!

My main point is that the font shouldn't change UI elements. I doubt it should be an icon: seems more like it should be a part of the theme.
Comment 7 Florian Müllner 2014-02-06 22:11:33 UTC
(In reply to comment #6)
> My main point is that the font shouldn't change UI elements. I doubt it should
> be an icon: seems more like it should be a part of the theme.

I think you agree - as I understand comment #5, Carlos is talking about an image file as part of the gnome-shell theme.
Comment 8 Carlos Soriano 2014-02-06 22:27:15 UTC
(In reply to comment #7)
> (In reply to comment #6)
> > My main point is that the font shouldn't change UI elements. I doubt it should
> > be an icon: seems more like it should be a part of the theme.
> 
> I think you agree - as I understand comment #5, Carlos is talking about an
> image file as part of the gnome-shell theme.

I meant that, yes.
Comment 9 Carlos Soriano 2014-02-18 12:49:53 UTC
Created attachment 269544 [details] [review]
popupMenu: Use an image for arrows

Until now the arrows were the associated arrow
character on the font. This cause some problems like
diferent arrows for diferent fonts, and size can be
altered because of the font size.
To solve that, use an image for the arrows.
Comment 10 Carlos Soriano 2014-02-18 14:51:10 UTC
Created attachment 269565 [details] [review]
popupMenu: Use an image for arrows

Until now the arrows were the associated arrow
character on the font. This cause some problems like
diferent arrows for diferent fonts, and size can be
altered because of the font size.
To solve that, use an image for the arrows.
Comment 11 Carlos Soriano 2014-02-18 14:51:27 UTC
Created attachment 269566 [details] [review]
popupMenu: Use relative rotation for arrows

Currently the animation of the arrows doesn't take
into account previous rotation.
Since in a incomming patch we will use one arrow
and rotate it to generate the four directions, we
need that the animation use relative rotation.
Comment 12 Carlos Soriano 2014-02-18 14:51:31 UTC
Created attachment 269567 [details] [review]
popupMenu: Use an image for arrows

Until now the arrows were the associated arrow
character on the font. This cause some problems like
diferent arrows for diferent fonts, and size can be
altered because of the font size.
To solve that, use an image for the arrows.
Comment 13 Carlos Soriano 2014-02-18 18:54:27 UTC
Created attachment 269590 [details] [review]
popupMenu: Use relative rotation for arrows

Currently the animation of the arrows doesn't take
into account previous rotation.
Since in a incomming patch we will use one arrow
and rotate it to generate the four directions, we
need that the animation use relative rotation.
Comment 14 Carlos Soriano 2014-02-18 18:54:32 UTC
Created attachment 269591 [details] [review]
popupMenu: Use an image for arrows

Until now the arrows were the associated arrow
character on the font. This cause some problems like
diferent arrows for diferent fonts, and size can be
altered because of the font size.
To solve that, use an image for the arrows.
Comment 15 Carlos Soriano 2014-02-18 19:03:15 UTC
Created attachment 269593 [details] [review]
popupMenu: Use relative rotation for arrows

Currently the animation of the arrows doesn't take
into account previous rotation.
Since in a incomming patch we will use one arrow
and rotate it to generate the four directions, we
need that the animation use relative rotation.
Comment 16 Carlos Soriano 2014-02-18 19:03:20 UTC
Created attachment 269594 [details] [review]
popupMenu: Use an image for arrows

Until now the arrows were the associated arrow
character on the font. This cause some problems like
diferent arrows for diferent fonts, and size can be
altered because of the font size.
To solve that, use an image for the arrows.
Comment 17 Allan Day 2014-02-18 19:35:16 UTC
Created attachment 269604 [details]
screenshot of the patches in action

Looks really good to me. The fuzziness from the previous triangles is gone too, which is great.
Comment 18 Carlos Soriano 2014-02-19 14:27:36 UTC
Created attachment 269686 [details] [review]
popupMenu: Rename _arrow_rotation to follow JS covention
Comment 19 Carlos Soriano 2014-02-19 14:27:41 UTC
Created attachment 269687 [details] [review]
popupMenu: Use relative rotation for arrows

Currently the animation of the arrows doesn't take
into account previous rotation.
Since in a incoming patch we will use one arrow
and rotate it to generate the four directions, we
need that the animation use relative rotation.
Comment 20 Carlos Soriano 2014-02-19 14:27:46 UTC
Created attachment 269688 [details] [review]
popupMenu: Use an image for arrows

Until now the arrows were the associated arrow
character of the font. This cause some problems like
different arrows for different fonts, and size can be
altered because of the font size.
To solve that, use an image for the arrows.
Comment 21 Carlos Soriano 2014-02-19 14:29:28 UTC
Patches pushed as:
4950bad2a7d92cbf75c95d809e9a2a6bf293550d
a7283864e80048a8fe9d74c5500b84ee71cac779
0418b68051e0bfec3e1a97344e105fa8c875ec05

Adding them here for reference