GNOME Bugzilla – Bug 712358
mssdemux: push language code tag
Last modified: 2014-05-04 10:26:38 UTC
The following patches add support for stream language tags. Unfortunatelly totem doesn't receive them probably because of #679768 or a similiar issue. It does work if I push the tags before *each* buffer and with this totem bug fixed: bug #712310
Created attachment 259862 [details] [review] mssmanifest: coding style fix Needed to make the git commit hook happy.
Created attachment 259863 [details] [review] mssmanifest: store the language of the stream
Created attachment 259864 [details] [review] mssdemux: push language code tag
Review of attachment 259864 [details] [review]: ::: ext/smoothstreaming/gstmssdemux.c @@ +1347,3 @@ } + push_stream_tags (mssdemux, stream); The tags should be pushed on the pad before the pad is exposed, that is before called gst_element_add_pad(). This also applies to the segment. I'm not sure why there is a pending_segments. So it should be pushed in gst_mss_demux_expose_stream() I think.
Review of attachment 259864 [details] [review]: ::: ext/smoothstreaming/gstmssdemux.c @@ +1347,3 @@ } + push_stream_tags (mssdemux, stream); Ah? I've been told to do it there on IRC.
commit f44c6ed52666d4c0529ebeb1ecd44828816e15e3 Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: Thu Nov 14 15:23:42 2013 +0100 mssdemux: push language code tag https://bugzilla.gnome.org/show_bug.cgi?id=712358 commit d6a9f17d8afe81aebdc96ad4bb7815fdcefdd4c0 Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: Thu Nov 14 15:14:18 2013 +0100 mssmanifest: store the language of the stream https://bugzilla.gnome.org/show_bug.cgi?id=712358
Comment on attachment 259864 [details] [review] mssdemux: push language code tag Pushed an updated version, marking this as obsolete