GNOME Bugzilla – Bug 709635
GNOME suggests that wifi killswitch can be disabled by software only
Last modified: 2013-10-08 20:46:15 UTC
This is a polish bug that I spotted during reporting bug 709634. In previous GNOME releases if I enabled wifi killswitch (hardware off), the wifi menu item said "hardware disabled" (or something similar). It was clear that it could not be operated by software only and some other action is required. In GNOME 3.10, the menu says Off, the as with software-disabled wifi. But when I click on Turn On, nothing happens. That will probably confuse some people. It would be much better if it said "hardware disabled" as in GNOME 3.8 and there was no Turn On at all. Please see attachment 256728 [details] from bug 709634. gnome-shell-3.10.0.1-1.fc20.x86_64 NetworkManager-0.9.9.0-12.git20130913.fc20.x86_64
The "Hardware disabled" status is bug 709043 (has patches, blocked by string freeze). Let's leave this one only for hiding "Turn on" when hw rfkilled.
Created attachment 256757 [details] [review] NetworkMenu: fix wireless-enabled property notifications The property is on the NMClient, not NMDevice. Also, make sure we disconnect the signal when the item is destroyed. Also, connect to wireless-hardware-enabled, which we'll use soon.
Created attachment 256758 [details] [review] NetworkMenu: hide the "Turn On" item when the rfkill is hardware blocked If wifi is disabled in hardware, there is nothing we can do at the sw level, so hide the menu item.
Review of attachment 256757 [details] [review]: OK.
Review of attachment 256758 [details] [review]: OK.
Attachment 256757 [details] pushed as 8a8b3bf - NetworkMenu: fix wireless-enabled property notifications Attachment 256758 [details] pushed as a6fb3ac - NetworkMenu: hide the "Turn On" item when the rfkill is hardware blocked