GNOME Bugzilla – Bug 706894
Cannot set the avatar for Telepathy accounts
Last modified: 2013-08-28 15:36:15 UTC
Selecting an avatar for Telepathy accounts doesn't work at the moment. It would be ideal if we could fix this for 3.10. Note that for avatars to work we also need to get the fix for bug #706881 by updating to the latest tp-aw after that bug fix is merged.
Created attachment 253254 [details] [review] telepathy: initialise the default Tp features in the Tp provider By initialising the default Telepathy features in the provider (so in libgoabackend) instead of in the daemon, we can rely on those features in every place where we use Telepathy. Ideally we should add a function to do this in tp-aw, but for now this is enough. See <https://bugzilla.gnome.org/show_bug.cgi?id=706892>.
Created attachment 253255 [details] [review] telepathy: we need the TpAccount's connection by default
Created attachment 253256 [details] [review] telepathy: initialise the features we need by default for TpConnection
Review of attachment 253254 [details] [review]: Looks good.
Review of attachment 253255 [details] [review]: Looks good, apart from one minor issue. ::: src/goabackend/goatelepathyprovider.c @@ -1037,3 +1040,2 @@ /* We make sure that new instances of Telepathy objects will have all * the features we need. */ - Looks a stray whitespace change.
Review of attachment 253256 [details] [review]: Looks good.
Pushed to master.
Comment on attachment 253255 [details] [review] telepathy: we need the TpAccount's connection by default You committed with the stray whitespace change, but it isn't a big deal.