After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706894 - Cannot set the avatar for Telepathy accounts
Cannot set the avatar for Telepathy accounts
Status: RESOLVED FIXED
Product: gnome-online-accounts
Classification: Core
Component: general
3.9.x
Other Linux
: Normal normal
: ---
Assigned To: Marco Barisione
GNOME Online Accounts maintainer(s)
Depends on: 706881
Blocks:
 
 
Reported: 2013-08-27 14:17 UTC by Marco Barisione
Modified: 2013-08-28 15:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
telepathy: initialise the default Tp features in the Tp provider (3.30 KB, patch)
2013-08-27 14:20 UTC, Marco Barisione
committed Details | Review
telepathy: we need the TpAccount's connection by default (1.12 KB, patch)
2013-08-27 14:20 UTC, Marco Barisione
committed Details | Review
telepathy: initialise the features we need by default for TpConnection (1.52 KB, patch)
2013-08-27 14:20 UTC, Marco Barisione
committed Details | Review

Description Marco Barisione 2013-08-27 14:17:34 UTC
Selecting an avatar for Telepathy accounts doesn't work at the moment. It would be ideal if we could fix this for 3.10.

Note that for avatars to work we also need to get the fix for bug #706881 by updating to the latest tp-aw after that bug fix is merged.
Comment 1 Marco Barisione 2013-08-27 14:20:40 UTC
Created attachment 253254 [details] [review]
telepathy: initialise the default Tp features in the Tp provider

By initialising the default Telepathy features in the provider (so in
libgoabackend) instead of in the daemon, we can rely on those features
in every place where we use Telepathy.

Ideally we should add a function to do this in tp-aw, but for now this
is enough. See <https://bugzilla.gnome.org/show_bug.cgi?id=706892>.
Comment 2 Marco Barisione 2013-08-27 14:20:43 UTC
Created attachment 253255 [details] [review]
telepathy: we need the TpAccount's connection by default
Comment 3 Marco Barisione 2013-08-27 14:20:46 UTC
Created attachment 253256 [details] [review]
telepathy: initialise the features we need by default for TpConnection
Comment 4 Debarshi Ray 2013-08-28 12:29:59 UTC
Review of attachment 253254 [details] [review]:

Looks good.
Comment 5 Debarshi Ray 2013-08-28 12:35:36 UTC
Review of attachment 253255 [details] [review]:

Looks good, apart from one minor issue.

::: src/goabackend/goatelepathyprovider.c
@@ -1037,3 +1040,2 @@
   /* We make sure that new instances of Telepathy objects will have all
    * the features we need. */
-

Looks a stray whitespace change.
Comment 6 Debarshi Ray 2013-08-28 12:38:30 UTC
Review of attachment 253256 [details] [review]:

Looks good.
Comment 7 Marco Barisione 2013-08-28 14:25:52 UTC
Pushed to master.
Comment 8 Debarshi Ray 2013-08-28 15:35:58 UTC
Comment on attachment 253255 [details] [review]
telepathy: we need the TpAccount's connection by default

You committed with the stray whitespace change, but it isn't a big deal.