GNOME Bugzilla – Bug 706542
some follow up smartcard fixes
Last modified: 2013-08-22 13:44:47 UTC
I've been doing some follow up testing of the smartcard stuff and hit a couple of bugs that fell out from the last round of the adjustments.
Created attachment 252677 [details] [review] objectManager: clear inhibitor on unregistered interfaces A D-Bus service can export more supported interfaces than the shell cares about. In those cases, we avoid creating proxies, but neglect to finish things up so the object manager class knows it can mark itself loaded. This commit makes sure we do the proper finishing, so the object manager still loads in the face of unsupported interfaces.
Created attachment 252678 [details] [review] gdmUtil: make _startService support no username commit fd11ad95f61b904d6f7014f8d56c1c27d88af65c factored out duplicated code, but unintentionally dropped support for beginning verification without a username. This commit brings it back.
Review of attachment 252678 [details] [review]: ::: js/gdm/util.js @@ +407,3 @@ + return; + } catch(e) { + this._reportInitError('Failed to start verification for user', e); "for user"?
Review of attachment 252677 [details] [review]: OK. ::: js/misc/objectManager.js @@ +73,2 @@ _addInterface: function(objectPath, interfaceName, onFinished) { let info = this._interfaceInfos[interfaceName]; Seems the indentation is also off here; followup commit?
Attachment 252677 [details] pushed as d29b86b - objectManager: clear inhibitor on unregistered interfaces Attachment 252678 [details] pushed as 9720301 - gdmUtil: make _startService support no username
(also pushed a separate indentation commit)