After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705433 - dlna-renderer: Wrap common error handling code in a macro
dlna-renderer: Wrap common error handling code in a macro
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
Depends on:
Blocks: 705439
 
 
Reported: 2013-08-04 09:01 UTC by Emanuele Aina
Modified: 2013-08-06 16:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dlna-renderer: Wrap common error handling code in a macro (6.45 KB, patch)
2013-08-04 09:01 UTC, Emanuele Aina 		committed Details | Review

Description Emanuele Aina 2013-08-04 09:01:53 UTC 
Error checking, propagation and async task unref'ing tends to be the same
everywhere, wrap it in a macro to slightly reduce the pain.
Comment 1 Emanuele Aina 2013-08-04 09:01:59 UTC 
Created attachment 250788 [details] [review]
dlna-renderer: Wrap common error handling code in a macro
Comment 2 Debarshi Ray 2013-08-06 16:12:18 UTC 
Review of attachment 250788 [details] [review]:

I like the idea of putting the __func__ in there. Maybe we could similarly wrap all the other error handling snippets throughout the code? But, anyway, thanks for the patch!