After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704015 - More height-for-width fixes
More height-for-width fixes
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on: 703810
Blocks:
 
 
Reported: 2013-07-11 15:32 UTC by Florian Müllner
Modified: 2013-08-20 06:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
modalDialog: Request HEIGHT_FOR_WIDTH (1.17 KB, patch)
2013-07-11 15:32 UTC, Florian Müllner
committed Details | Review
networkAgent: Remove height-for-width hack (1.72 KB, patch)
2013-07-11 15:32 UTC, Florian Müllner
committed Details | Review

Description Florian Müllner 2013-07-11 15:32:22 UTC
I knew there was another hfw workaround lurking around somewhere ...
Comment 1 Florian Müllner 2013-07-11 15:32:28 UTC
Created attachment 248936 [details] [review]
modalDialog: Request HEIGHT_FOR_WIDTH

All our modal dialogs are given a fixed width and grow vertically
as necessary. Set the request mode accordingly, so that wrapped
labels are considered correctly during size request, and not only
at allocation time (where they'll either take away from the padding
or even cause the dialog to overflow).
Comment 2 Florian Müllner 2013-07-11 15:32:33 UTC
Created attachment 248937 [details] [review]
networkAgent: Remove height-for-width hack

ClutterBoxLayout has proper height-for-width support, so make use
of it.
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-07-11 16:56:33 UTC
Review of attachment 248936 [details] [review]:

A comment summarizing the commit message would be appreciated.

::: js/ui/modalDialog.js
@@ +80,2 @@
         this.dialogLayout = new St.BoxLayout({ style_class: 'modal-dialog',
                                                vertical:    true });

Why not in the property bag?
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-07-11 16:56:47 UTC
Review of attachment 248937 [details] [review]:

OK.
Comment 5 Florian Müllner 2013-07-11 17:02:52 UTC
(In reply to comment #3)
> Why not in the property bag?

Long line, old fart, 80-char terminal :-)
Comment 6 Florian Müllner 2013-08-20 06:41:56 UTC
Attachment 248936 [details] pushed as 00ccbda - modalDialog: Request HEIGHT_FOR_WIDTH
Attachment 248937 [details] pushed as c37c4d8 - networkAgent: Remove height-for-width hack