After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 703978 - Move from libgd-widgets to stable Gtk-widgets
Move from libgd-widgets to stable Gtk-widgets
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2013-07-11 01:28 UTC by Mattias Bengtsson
Modified: 2014-01-05 00:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove Sidebar (6.29 KB, patch)
2013-08-06 01:12 UTC, Mattias Bengtsson 		rejected Details | Review
Move from Gd to Gtk+ when possible (3.37 KB, patch)
2013-08-06 01:13 UTC, Mattias Bengtsson 		accepted-commit_now Details | Review
Move from Gd to Gtk+ when possible (3.50 KB, patch)
2013-08-06 22:53 UTC, Mattias Bengtsson 		none Details | Review

Description Mattias Bengtsson 2013-07-11 01:28:49 UTC 
A lot of the widgets in libgd has already or are in the process of being mergedd into Gtk+. We should update gnome-maps to use the stable Gtk+ versions when possible.

We currently use the following widgets from libgd:
 - GdHeaderBar (GtkHeaderBar in Gtk+ 3.9)
 - GdRevealer (GtkRevealer in Gtk+ 3.9)
 - GdHeaderToggleButton
 - GdHeaderMenuButton
 - GdTaggedEntry

The last three I don't know much about. Let's keep this bug as a tracker for our progress on moving to stock gtk widgets.
Comment 1 Mattias Bengtsson 2013-08-06 01:12:58 UTC 
Created attachment 250914 [details] [review]
Remove Sidebar

This removes the sidebar from master as it isn't used and since I want to
update Maps to not use libgd as much without having to update this file.
The wip/osrm-routing branch still has it (and I will remove unneeded
libgd-references from it before posting patches at bugzilla).
Comment 2 Mattias Bengtsson 2013-08-06 01:13:02 UTC 
Created attachment 250915 [details] [review]
Move from Gd to Gtk+ when possible

A lot of functionality from libgd has been merged into Gtk+. This patch
removes as much of libgd from Maps as possible.
Comment 3 Mattias Bengtsson 2013-08-06 01:13:52 UTC 
These patches depend on the patches in https://bugzilla.gnome.org/show_bug.cgi?id=705537
Comment 4 Zeeshan Ali 2013-08-06 16:34:23 UTC 
Review of attachment 250914 [details] [review]:

So in other words, you'll re-add this sidebar again very soon? I don't see the point of temporarily removing some code.
Comment 5 Zeeshan Ali 2013-08-06 16:37:07 UTC 
Review of attachment 250915 [details] [review]:

Looks good otherwise but please add the following to the commit log:

* GdHeaderBar -> GtkHeaderBar
* GdHeaderToggleButton -> GtkToggleButton
* GdHeaderMenuButton -> GtkMenuButton
Comment 6 Mattias Bengtsson 2013-08-06 22:48:48 UTC 
Review of attachment 250915 [details] [review]:

Ok sure will do that.
Comment 7 Mattias Bengtsson 2013-08-06 22:50:15 UTC 
Review of attachment 250914 [details] [review]:

The reason would be me not needing to port this twice in two different ways since I've already ported the sidebar to a .ui-file in the osrm-routing branch. Porting the .ui-file is also much easier / faster than porting code.
Comment 8 Mattias Bengtsson 2013-08-06 22:53:33 UTC 
Created attachment 251005 [details] [review]
Move from Gd to Gtk+ when possible

A lot of functionality from libgd has been merged into Gtk+. This patch
removes as much of libgd from Maps as possible.

Specifically:
* GdHeaderBar          -> GtkHeaderBar
* GdHeaderToggleButton -> GtkToggleButton
* GdHeaderMenuButton   -> GtkMenuButton
Comment 9 Mattias Bengtsson 2014-01-05 00:03:17 UTC 
This was fixed a while ago.